@module-federation/bridge-react package bundles react-dom/client (v18) code

[francisduvivier]

Describe the bug

When we were trying to use bridge-react to include a react v19 federated module safely into a react v18 host with react-bridge and react-runtime, we noticed that it does not work. The first reason for this that we can see is that the @module-federation/bridge-react is currently bundling react-dom/client.

This bundling looks accidental to me, so I opened a PR to fix it ( #3476 ).

Reproduction

• Check out this repository

• build the bridge-react package

• check the imports in bridge-react/dist/index.es.js

  • You will see that there is no import for react-dom/client, instead the code is bundled below containing __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED on line 333

• Alternatively to the steps above you can also check the bundle at https://www.npmjs.com/package/@module-federation/bridge-react?activeTab=code and then @module-federation/bridge-react/dist/index.es.js line 333

Used Package Manager

pnpm

System Info

Not applicable

Validations

• Read the docs.
• Read the common issues list.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Module federation issue and not a framework-specific issue.
• The provided reproduction is a minimal reproducible example of the bug.

[danpeen]

issue fixed.