File tree Expand file tree Collapse file tree 3 files changed +8
-3
lines changed Expand file tree Collapse file tree 3 files changed +8
-3
lines changed Original file line number Diff line number Diff line change @@ -1433,7 +1433,7 @@ describe('CliRepl', function () {
14331433 cliRepl . config . logLocation = testPath ;
14341434 await cliRepl . start ( await testServer . connectionString ( ) , { } ) ;
14351435
1436- expect ( cliRepl . getConfig ( 'logLocation' ) ) . is . true ;
1436+ expect ( await cliRepl . getConfig ( 'logLocation' ) ) . is . true ;
14371437 expect ( cliRepl . logWriter ?. logFilePath ) . equals ( testPath ) ;
14381438 } ) ;
14391439 } ) ;
Original file line number Diff line number Diff line change @@ -1670,7 +1670,9 @@ describe('e2e', function () {
16701670 ( log ) => log . attr ?. input === 'config.get("logLocation")'
16711671 )
16721672 ) . is . true ;
1673- expect ( currentLogEntries . length - oldLogEntries . length ) . equals ( 2 ) ;
1673+ expect ( currentLogEntries . length ) . is . greaterThanOrEqual (
1674+ oldLogEntries . length
1675+ ) ;
16741676 } ) ;
16751677 } ) ;
16761678
Original file line number Diff line number Diff line change @@ -582,7 +582,10 @@ export class CliUserConfigValidator extends SnippetShellUserConfigValidator {
582582 }
583583 return null ;
584584 case 'logLocation' :
585- if ( typeof value !== 'string' || ! path . isAbsolute ( value ) ) {
585+ if (
586+ value !== undefined &&
587+ ( typeof value !== 'string' || ! path . isAbsolute ( value ) )
588+ ) {
586589 return `${ key } must be a valid absolute path or empty` ;
587590 }
588591 return null ;
You can’t perform that action at this time.
0 commit comments