Skip to content

Commit ed6c929

Browse files
committed
Remove client arg from _get_encrypted_fields
- client need not be an argument since it can be accessed using self.connection.connection
1 parent a02484f commit ed6c929

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

django_mongodb_backend/management/commands/showencryptedfieldsmap.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,13 @@ def handle(self, *args, **options):
3535
db = options["database"]
3636
create_data_keys = options.get("create_data_keys", False)
3737
connection = connections[db]
38-
client = connection.connection
3938
encrypted_fields_map = {}
4039
with connection.schema_editor() as editor:
4140
for app_config in apps.get_app_configs():
4241
for model in router.get_migratable_models(app_config, db):
4342
if model_has_encrypted_fields(model):
4443
fields = editor._get_encrypted_fields(
45-
model, client, create_data_keys=create_data_keys
44+
model, create_data_keys=create_data_keys
4645
)
4746
encrypted_fields_map[model._meta.db_table] = fields
4847
self.stdout.write(json_util.dumps(encrypted_fields_map, indent=2))

django_mongodb_backend/schema.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -474,7 +474,7 @@ def _create_collection(self, model):
474474
)
475475
encrypted_fields_map = getattr(auto_encryption_opts, "_encrypted_fields_map", None)
476476
if not encrypted_fields_map:
477-
encrypted_fields = self._get_encrypted_fields(model, client, create_data_keys=True)
477+
encrypted_fields = self._get_encrypted_fields(model, create_data_keys=True)
478478
else:
479479
# If the encrypted fields map is provided, get the encrypted fields for the
480480
# specific collection.
@@ -484,14 +484,15 @@ def _create_collection(self, model):
484484
db.create_collection(db_table)
485485

486486
def _get_encrypted_fields(
487-
self, model, client, create_data_keys=False, key_alt_name=None, client_encryption=None
487+
self, model, create_data_keys=False, key_alt_name=None, client_encryption=None
488488
):
489489
"""
490490
Recursively collect encryption schema data for fields in a model.
491491
492492
key_alt_name is the base path for this level, typically model._meta.db_table
493493
"""
494494
connection = self.connection
495+
client = connection.connection
495496
fields = model._meta.fields
496497
key_alt_name = key_alt_name or model._meta.db_table
497498

@@ -548,7 +549,6 @@ def _get_encrypted_fields(
548549
field_list.append(field_dict)
549550
embedded_result = self._get_encrypted_fields(
550551
field.embedded_model,
551-
client,
552552
create_data_keys=create_data_keys,
553553
key_alt_name=new_path,
554554
client_encryption=client_encryption,

0 commit comments

Comments
 (0)