INTPYTHON-483 Add querying support for EmbeddedModelArrayField#303
Merged
Conversation
WaVEV
force-pushed
the
arrayfield+emf-querying
branch
from
fc53f56 to
c446c49
Compare
timgraham
changed the title
WaVEV
force-pushed
the
arrayfield+emf-querying
branch
4 times, most recently
from
9850b66 to
f50337f
Compare
WaVEV
force-pushed
the
arrayfield+emf-querying
branch
6 times, most recently
from
41f1843 to
ca7a7b3
Compare
Jibola
approved these changes
May 29, 2025
WaVEV
force-pushed
the
arrayfield+emf-querying
branch
3 times, most recently
from
744a9ef to
f6625d9
Compare
timgraham
changed the title
WaVEV
force-pushed
the
arrayfield+emf-querying
branch
3 times, most recently
from
b4e627e to
e40bea8
Compare
timgraham
force-pushed
the
arrayfield+emf-querying
branch
from
26b63d9 to
c97ef18
Compare
timgraham
reviewed
Jun 3, 2025
timgraham
force-pushed
the
arrayfield+emf-querying
branch
2 times, most recently
from
4e5e57c to
5e66c91
Compare
Otherwise, they collide with django.contrib.postgres's ArrayField.
timgraham
force-pushed
the
arrayfield+emf-querying
branch
from
5e66c91 to
13efcd1
Compare
timgraham
reviewed
Jul 2, 2025
Comment on lines
+255
to
+263
| def test_invalid_lookup(self): | ||
| msg = "Unsupported lookup 'return' for EmbeddedModelArrayField of 'IntegerField'" | ||
| with self.assertRaisesMessage(FieldDoesNotExist, msg): | ||
| Exhibit.objects.filter(sections__section_number__return=3) | ||
|
|
||
| def test_invalid_operation(self): | ||
| msg = "Unsupported lookup 'rage' for EmbeddedModelArrayField of 'IntegerField'" | ||
| with self.assertRaisesMessage(FieldDoesNotExist, msg): | ||
| Exhibit.objects.filter(sections__section_number__rage=[10]) |
Collaborator
There was a problem hiding this comment.
Is the second test redundant?
Collaborator
Author
There was a problem hiding this comment.
I wanted to test range, given that range is a numerical operation but isn't allowed in EmbeddedModelArrayField. So, It was a test to prove the lookups are only the allowed by the scalar type (in this case numeric) and the allowed by the EMAF. But Rage does not exist in both, there are other test with range but was over json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(initial review comments at timgraham#9)