enforce function return types

Author: Ferotiq

.eslintrc.json

@@ -14,7 +14,13 @@
     "no-unused-vars": "off",
     "@typescript-eslint/no-unused-vars": "error",
     "curly": ["error", "all"],
-    "eqeqeq": ["error", "always"]
+    "eqeqeq": ["error", "always"],
+    "@typescript-eslint/explicit-function-return-type": [
+      "error",
+      {
+        "allowExpressions": true
+      }
+    ]
   },
   "plugins": ["prettier"]
 }

src/commands/banana/banana-rps.ts

@@ -140,7 +140,7 @@ export default {
         "BUTTON"
       );
 
-      async function finishRound() {
+      async function finishRound(): Promise<void> {
         if (round !== 3) {
           const roundField = embed.fields[0];
 

src/events/ready.ts

@@ -66,7 +66,7 @@ interface GitHubLabel {
   name: string;
 }
 
-async function fetchLabels(client: Client<true>) {
+async function fetchLabels(client: Client<true>): Promise<void> {
   console.log("Fetching GitHub labels...");
 
   const response = await fetch(
@@ -89,7 +89,7 @@ async function fetchLabels(client: Client<true>) {
   updateIssueCommand(client);
 }
 
-async function updateIssueCommand(client: Client<true>) {
+async function updateIssueCommand(client: Client<true>): Promise<void> {
   console.log("Updating issue command...");
 
   const labels = parseJSON<string[]>(readFileOrCreate("labels.json", "[]"));

src/functions/banana.ts

@@ -56,7 +56,7 @@ export function getData(): MonkeyTypes.BananaData {
   );
 }
 
-function setData(bananaData: MonkeyTypes.BananaData) {
+function setData(bananaData: MonkeyTypes.BananaData): void {
   fs.writeFileSync("bananas.json", JSON.stringify(bananaData, null, 2));
 }
 

src/functions/mongodb.ts

@@ -1,10 +1,10 @@
 /** @format */
 
-import { MongoClient } from "mongodb";
+import { Db, MongoClient } from "mongodb";
 
 let mongoClient: MongoClient;
 
-export async function connectDB() {
+export async function connectDB(): Promise<MongoClient> {
   const dbURI = process.env["DB_URI"];
 
   if (!dbURI) {
@@ -24,6 +24,6 @@ export async function connectDB() {
   return mongoClient;
 }
 
-export function mongoDB() {
+export function mongoDB(): Db {
   return mongoClient.db(process.env["DB_NAME"]);
 }

src/functions/redis.ts

@@ -4,7 +4,7 @@ import Redis from "ioredis";
 
 let redisClient: Redis;
 
-export async function connectRedis() {
+export async function connectRedis(): Promise<Redis> {
   const redisURI = process.env["REDIS_URI"];
 
   if (!redisURI) {
@@ -21,6 +21,6 @@ export async function connectRedis() {
   return redisClient;
 }
 
-export function redis() {
+export function redis(): Redis {
   return redisClient;
 }

src/structures/client.ts

@@ -144,7 +144,7 @@ export class Client<T extends boolean> extends Discord.Client<T> {
     console.log(`Initialized task worker "${worker.name}"`);
   }
 
-  public async start(token: string) {
+  public async start(token: string): Promise<string> {
     await this.login(token);
 
     const [commands, events] = await this.load();
@@ -244,7 +244,9 @@ export class Client<T extends boolean> extends Discord.Client<T> {
           console.log(`Created slash command "${c.name}" (${c.id})`);
         }
       } else {
-        const mapper = (option: Discord.ApplicationCommandOption) => {
+        const mapper = (
+          option: Discord.ApplicationCommandOption
+        ): Discord.ApplicationCommandOption => {
           type Keys = keyof typeof option;
 
           type Values = typeof option[Keys];
@@ -297,7 +299,10 @@ export class Client<T extends boolean> extends Discord.Client<T> {
     return [this.commands.size, events.length];
   }
 
-  public embed(embedOptions: Discord.MessageEmbedOptions, user?: Discord.User) {
+  public embed(
+    embedOptions: Discord.MessageEmbedOptions,
+    user?: Discord.User
+  ): Discord.MessageEmbed {
     // if (!embedOptions.title?.startsWith(this.user?.username ?? "George")) {
     // embedOptions.title = `${this.user?.username ?? "George"}: \`${
     //   embedOptions.title
@@ -323,7 +328,7 @@ export class Client<T extends boolean> extends Discord.Client<T> {
     return embed;
   }
 
-  public async paginate<T>(options: PaginationOptions<T>) {
+  public async paginate<T>(options: PaginationOptions<T>): Promise<void> {
     const {
       embedOptions,
       interaction,