Simplify the generated C# for marshalling strings

Signed-off-by: Dimitar Dobrev <[email protected]>

Author: ddobrev

src/Generator/Generators/CSharp/CSharpTypePrinter.cs

@@ -129,7 +129,7 @@ public override TypePrinterResult VisitArrayType(ArrayType array,
             if (arrayType.IsPointerToPrimitiveType(PrimitiveType.Char))
             {
                 var prefix = ContextKind == TypePrinterContextKind.Managed ? string.Empty :
-                    "[MarshalAs(UnmanagedType.LPArray, ArraySubType = UnmanagedType.LPStr)] ";
+                    "[MarshalAs(UnmanagedType.LPArray)] ";
                 return $"{prefix}string[]";
             }
 

src/Generator/Passes/DelegatesPass.cs

@@ -276,7 +276,6 @@ private static StringBuilder FormatTypesStringForIdentifier(StringBuilder types)
         {
             // TODO: all of this needs proper general fixing by only leaving type names
             return types.Replace("global::System.", string.Empty)
-                .Replace("[MarshalAs(UnmanagedType.LPStr)] ", string.Empty)
                 .Replace("[MarshalAs(UnmanagedType.LPWStr)] ", string.Empty)
                 .Replace("global::", string.Empty).Replace("*", "Ptr")
                 .Replace('.', '_').Replace(' ', '_').Replace("::", "_")

src/Generator/Types/Std/Stdlib.cs

@@ -155,7 +155,7 @@ public override Type CSharpSignatureType(TypePrinterContext ctx)
             }
 
             if (Context.Options.Encoding == Encoding.ASCII)
-                return new CustomType("[MarshalAs(UnmanagedType.LPStr)] string");
+                return new CustomType("string");
 
             if (Context.Options.Encoding == Encoding.Unicode ||
                 Context.Options.Encoding == Encoding.BigEndianUnicode)