Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSL not adding launchers shortcuts to bazzite #530

Open
hyggli opened this issue Dec 11, 2024 · 14 comments
Open

NSL not adding launchers shortcuts to bazzite #530

hyggli opened this issue Dec 11, 2024 · 14 comments

Comments

@hyggli
Copy link

hyggli commented Dec 11, 2024

I have bazzite, last version.
I installed decky and now nsl.
I installed the launchers, but they run very fast and the program says they are installed, but no message for the shortcuts.

I can't see them in my steam library anywhere
Any thoughts?

@moraroy
Copy link
Owner

moraroy commented Dec 11, 2024

@hyggli I have no idea, as I don't use bazzite , you may have to ask the developer of that program why it's not working haha do you have any logs?

@crazysmurf
Copy link

@moraroy I ran into same issue. Checked NSL logs. Mainly the distro is missing env_vars:

[2024-12-26 22:40:49,553][ERROR]: Error: /home/bazzite/.config/systemd/user/env_vars does not exist.
[2024-12-26 22:40:49,553][ERROR]: Error handling request
Traceback (most recent call last):
File "aiohttp/web_protocol.py", line 477, in _handle_request
File "aiohttp/web_app.py", line 559, in _handle
File "/home/bazzite/homebrew/plugins/NonSteamLaunchers/main.py", line 214, in handleCustomSite
decky_shortcuts = addCustomSite(msg.data)
^^^^^^^^^^^^^^^^^^^^^^^
File "/var/home/bazzite/homebrew/plugins/NonSteamLaunchers/py_modules/lib/scanner.py", line 132, in addCustomSite
create_new_entry(env_vars.get('chromedirectory'), customSiteName, chromelaunch_options, env_vars.get('chrome_startdir'), None)
^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'get'

@moraroy
Copy link
Owner

moraroy commented Dec 27, 2024

@crazysmurf @hyggli thank you I'll fix soon

@moraroy
Copy link
Owner

moraroy commented Dec 27, 2024

@crazysmurf make sure you install a launcher first, this will create the env_vars then try to use the website shortcut

@crazysmurf
Copy link

crazysmurf commented Dec 27, 2024

@moraroy Tried to install battle.net but same results:
(Edit: Tried installing EPIC launcher as well and same result)

[2024-12-27 14:19:26,199][INFO]: Returning cached update information.
[2024-12-27 14:19:26,220][ERROR]: Missing return statement on request handler
Traceback (most recent call last):
File "aiohttp/web_protocol.py", line 653, in finish_response
AttributeError: 'NoneType' object has no attribute 'prepare'
[2024-12-27 14:19:26,220][INFO]: ::1 [27/Dec/2024:14:19:26 -0800] "GET /check_update HTTP/1.1" 500 0 "-" "Mozilla/5.0 (X11; Linux x86_64; Valve Steam Client/Steam Deck [Steam Deck Stable]/default/0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.6478.183 Safari/537.36"
[2024-12-27 14:19:29,862][ERROR]: Missing return statement on request handler
Traceback (most recent call last):
File "aiohttp/web_protocol.py", line 653, in finish_response
AttributeError: 'NoneType' object has no attribute 'prepare'
[2024-12-27 14:19:29,863][INFO]: ::1 [27/Dec/2024:14:19:29 -0800] "GET /launcher_status HTTP/1.1" 500 0 "-" "Mozilla/5.0 (X11; Linux x86_64; Valve Steam Client/Steam Deck [Steam Deck Stable]/default/0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.6478.183 Safari/537.36"
[2024-12-27 14:19:34,144][INFO]: Refreshing environment variables...
[2024-12-27 14:19:34,144][INFO]: Running on Linux or other OS
[2024-12-27 14:19:34,144][ERROR]: Error: /home/bazzite/.config/systemd/user/env_vars does not exist.
[2024-12-27 14:19:34,144][INFO]: No shortcuts to send
[2024-12-27 14:19:56,166][INFO]: Exiting AutoScan loop
[2024-12-27 14:19:56,166][INFO]: ::1 [27/Dec/2024:10:03:11 -0800] "GET /autoscan HTTP/1.1" 101 0 "-" "Mozilla/5.0 (X11; Linux x86_64; Valve Steam Client/Steam Deck [Steam Deck Stable]/default/0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.6478.183 Safari/537.36"
[2024-12-27 14:19:56,166][INFO]: Exiting AutoScan loop
[2024-12-27 14:19:56,166][INFO]: ::1 [27/Dec/2024:10:05:37 -0800] "GET /autoscan HTTP/1.1" 101 0 "-" "Mozilla/5.0 (X11; Linux x86_64; Valve Steam Client/Steam Deck [Steam Deck Stable]/default/0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.6478.183 Safari/537.36"
[2024-12-27 14:19:56,166][INFO]: Exiting AutoScan loop
[2024-12-27 14:19:56,166][INFO]: ::1 [27/Dec/2024:10:27:01 -0800] "GET /autoscan HTTP/1.1" 101 0 "-" "Mozilla/5.0 (X11; Linux x86_64; Valve Steam Client/Steam Deck [Steam Deck Stable]/default/0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.6478.183 Safari/537.36"
[2024-12-27 14:19:56,452][INFO]: install was called
[2024-12-27 14:19:56,452][INFO]: selected_options: BattleNet
[2024-12-27 14:19:56,452][INFO]: separate_app_ids: False
[2024-12-27 14:19:56,452][INFO]: start_fresh: False
[2024-12-27 14:19:56,452][INFO]: install_chrome: False
[2024-12-27 14:19:56,452][INFO]: update_proton_ge: False
[2024-12-27 14:19:56,452][INFO]: nslgamesaves: False
[2024-12-27 14:19:56,452][INFO]: selected_option_nice: Battle.net
[2024-12-27 14:19:56,454][INFO]: Running command: /home/bazzite/homebrew/plugins/NonSteamLaunchers/NonSteamLaunchers.sh " Battle.net" "DeckyPlugin"
[2024-12-27 14:19:56,456][INFO]: Command exit code: 127
[2024-12-27 14:19:56,475][INFO]: Called Manual Scan
[2024-12-27 14:19:56,475][INFO]: Refreshing environment variables...
[2024-12-27 14:19:56,475][INFO]: Running on Linux or other OS
[2024-12-27 14:19:56,475][ERROR]: Error: /home/bazzite/.config/systemd/user/env_vars does not exist.
[2024-12-27 14:19:56,475][INFO]: No shortcuts to send
[2024-12-27 14:19:56,475][INFO]: Running Manual Game Save backup...
[2024-12-27 14:19:56,497][INFO]: Manual Game Save Backup completed
[2024-12-27 14:19:56,497][INFO]: ::1 [27/Dec/2024:14:19:56 -0800] "GET /scan HTTP/1.1" 101 0 "-" "Mozilla/5.0 (X11; Linux x86_64; Valve Steam Client/Steam Deck [Steam Deck Stable]/default/0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.6478.183 Safari/537.36"
[2024-12-27 14:20:01,487][INFO]: AutoScan: True
[2024-12-27 14:20:01,488][INFO]: Refreshing environment variables...
[2024-12-27 14:20:01,488][INFO]: Running on Linux or other OS
[2024-12-27 14:20:01,488][ERROR]: Error: /home/bazzite/.config/systemd/user/env_vars does not exist.
[2024-12-27 14:20:01,488][INFO]: No shortcuts to send

@crazysmurf
Copy link

Looks like there's a few things missing, so I decide to generate a fresh log. What I did:

Rebooted my linux box into gamescope and went to decky -> nsl -> enable EPIC -> install. Then I went to desktop and attach the whole log file here.

2024-12-27 14.39.42.log

@moraroy
Copy link
Owner

moraroy commented Dec 28, 2024

@crazysmurf thank you that's helpful, can you also show me a fresh log from trying to install a launcher, I need the specific log from the /home/deck/downloads folder. Since you guys are on bazzite it may look different. From here I can see where it's failing.

@crazysmurf
Copy link

@moraroy I don't see anything downloaded to Downloads folder (aside from what i've downloaded). Bazzite distro did a few symlinks, so /home/deck is basically pointing to /var/home/bazzite.

bazzite@bazzite ~> ls -la /home
lrwxrwxrwx. 3 root root 8 Dec 1 21:22 /home -> var/home/

bazzite@bazzite ~> ls -la /var/home/deck
lrwxrwxrwx. 1 root root 13 Dec 1 21:57 /var/home/deck -> /home/bazzite/

bazzite@bazzite ~> ls -la /home/deck/Downloads/
total 24
drwxr-xr-x. 1 bazzite bazzite 150 Dec 27 14:54 ./
drwx------. 1 bazzite bazzite 922 Dec 27 20:14 ../
-rw-r--r--. 1 bazzite bazzite 498 Dec 27 14:27 NonSteamLaunchers.desktop.download
-rwxr--r--. 1 bazzite bazzite 532 Dec 26 22:39 NSLPlugin.desktop.download*
-rw-r--r--. 1 bazzite bazzite 12493 Dec 3 01:54 plex-poster.png

bazzite@bazzite ~> readlink -f /home/deck/Downloads
/var/home/bazzite/Downloads

Is there anywhere else the logs will write to besides /home/bazzite/homebrew/logs? (that's where I pull the fresh launcher install log from)

@moraroy
Copy link
Owner

moraroy commented Dec 28, 2024

The only logs for nonsteamlaunchers are located in /home/deck/Downloads and /home/deck/homebrew/logs/NonSteamLaunchers. I see now that if the log itself isn't even being written to, it means the the actual script itself isn't firing. So that's why nothing is installing. Give me some time and I will do my best to gather what I've learned from these logs and I'll see if I can figure out what are the corrects paths on the bazzite distro.

@crazysmurf
Copy link

@moraroy I've compared the installation on my steam deck vs bazzite and looks like the install on bazzite didnt work correctly. From what I can tell, some files werent installed:

bazzite@bazzite ~/.c/s/user> ls -la
total 4
drwxr-xr-x. 1 bazzite bazzite 48 Dec 11 22:59 ./
drwxr-xr-x. 1 bazzite bazzite 8 Dec 11 22:59 ../
-rw-r--r--. 1 bazzite bazzite 162 Dec 22 00:12 EmuDeckCloudSync.service
bazzite@bazzite ~/.c/s/user> pwd
/home/bazzite/.config/systemd/user

I assume there should be some nsl services that should be here? Is there an install log somewhere I can check? Also, are there any python modules that your code expects but probably wasn't installed?

Let me know what you want me to check.

@moraroy
Copy link
Owner

moraroy commented Dec 28, 2024

Are you mainly using the desktop version of NSL or the decky plugin version?

@crazysmurf
Copy link

@moraroy I use decky plugin version.

Also, just did a quick test on the cli install on epic launcher. That seemed to work. I then go back to "Gaming Mode" (which basically reboots the bazzite and boot into gamescope - big picture). When I go decky -> nsl -> launchers, I see Epic is green. I then ran a manual scan and EPIC shows up on non-steam. I then tried to install/enable streaming services via decky -> nsl and those showed up as non-steam, with the properties filled in, etc (i've enabled netflix, hulu, d+, youtube, etc).

So, it looks like once I've done the first install, things worked. (However, on my steam deck, I went through decky -> nsl to install EPIC and it worked, so something wasn't quite right with bazzite install the first time. btw, bazzite is fedora based)

What I did in CLI:
bazzite@bazzite ~> cd homebrew/plugins/NonSteamLaunchers/
bazzite@bazzite ~/h/p/NonSteamLaunchers> ./NonSteamLaunchers.sh -- "Epic Games"

@moraroy
Copy link
Owner

moraroy commented Jan 6, 2025

@crazysmurf the issue that I can see for nsl right now, is some paths don't match up and my logic in how nsl handles the environment variables. Will try my best to fix this very soon, hopefully this will fix that "first run bug" you described, thank you for troubleshooting and being patient

@crazysmurf
Copy link

@moraroy no worries. Just strange that I can't install launchers initially when it works perfectly fine on my steam deck. And now after I did the first install via cli, everything works as it should.

Note that since I have my set up working now, I won't be able to have testing done as quickly, for I'll need to set up another machine to test the scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants