Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Extension publishing fails #21

Closed
Philipp15b opened this issue May 19, 2024 · 1 comment · Fixed by #26
Closed

CI: Extension publishing fails #21

Philipp15b opened this issue May 19, 2024 · 1 comment · Fixed by #26
Assignees
Labels
bug Something isn't working

Comments

@Philipp15b
Copy link
Collaborator

See https://github.com/moves-rwth/caesar/actions/runs/9150425689/job/25155182535.

I've tried to publish locally, and now I'm getting again:

This extension consists of 1356 files, out of which 830 are JavaScript files. For performance reasons, you should bundle your extension: https://aka.ms/vscode-bundle-extension . You should also exclude unnecessary files by adding them to your .vscodeignore: https://aka.ms/vscode-vscodeignore

See #16.

The CI script seems to have this --out parameter for which I cannot find the documentation?

npm run package -- --out caesar-${{ inputs.version }}.vsix
@darionhaase
Copy link
Member

darionhaase commented May 27, 2024

I've tried to publish locally, and now I'm getting again:

This extension consists of 1356 files, out of which 830 are JavaScript files. For performance reasons, you should bundle your extension: https://aka.ms/vscode-bundle-extension . You should also exclude unnecessary files by adding them to your .vscodeignore: https://aka.ms/vscode-vscodeignore

See #16.

This seems to only affect manual publishing and is not responsible for the failure of the CI. At least no such warning is present in the CI logs. I will have a look at the 'unnecessary files' problem in #16.

The workflow failed because of missing secrets, see #21.

The CI script seems to have this --out parameter for which I cannot find the documentation?

npm run package -- --out caesar-${{ inputs.version }}.vsix

This flag is used to set the filename of the extension, see https://github.com/microsoft/vscode-vsce/blob/fd9a2627e29c031829e550b9bde2ce2282d99a3d/src/main.ts#L86
Previously, I did this renaming manually with an additional workflow step (which lead to even more confusion).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants