v0.0.8-dev has wrong line endings for lockdown-relock file

[rjmunro]

I ran the following on OS X:

$ npm install --save lockdown@0.0.8-dev
[trim output]
$ ./node_modules/.bin/lockdown-relock 
env: node\r: No such file or directory

The shebang line is looking for a command node\r (where \r is a literal carriage return character) because the line endings are windows not unix. As a workaround you can run node manually node ./node_modules/.bin/lockdown-relock - node itself does not care about the line endings.

[hermanbanken]

+1

[hermanbanken]

Saving the file ./node_modules/.bin/lockdown with Linux line endings is another work around. Causes npm install to succeed again.

[stwr667]

+1 for a fix. I can fix it locally using @hermanbanken's suggestion. But when trying to create a PR for the fix, for some reason I didn't have the same issue.
Anyone else able to fix this?

[marnen]

@stwr667 Is your Git line ending configuration getting in the way of making a PR, perchance? (Just a guess. I haven't tried to do this yet.)

[nettum]

This only seems to be a problem with the package that is published to registry.npmjs.org.

When I clone the project directly from github the line endings are fine:

$ git clone git@github.com:mozilla/npm-lockdown.git
$ cd npm-lockdown/
$ file lockdown.js relock.js 
lockdown.js: Node.js script, ASCII text executable
relock.js:   Node.js script, ASCII text executable

I also get the correct line endings when I download the zip-file from github.

But when I use npm install the line endrings are wrong:

$ npm install lockdown
$ file node_modules/lockdown/lockdown.js node_modules/lockdown/relock.js 
node_modules/lockdown/lockdown.js: Node.js script, ASCII text executable, with CRLF line terminators
node_modules/lockdown/relock.js:   Node.js script, ASCII text executable, with CRLF line terminators

The tarball that is downloaded by npm is this one: http://registry.npmjs.org/lockdown/-/lockdown-0.0.8-dev.tgz

I think maybe the version should be bumped and a new tarball published to registry.npmjs.org.
What do you think @seanmonstar ?

[ryuran]

+1 same error here

$ ./node_modules/.bin/lockdown-relock 
env: node\r: No such file or directory

[tylercollier]

+1

Thanks to @rjmunro for the fix:

node ./node_modules/.bin/lockdown-relock

[dyg2104MD]

+1 same error

[janpaul123]

+1

[saponifi3d]

+1

[palmerj3]

+1

[choongmanee]

+1

[mglinski]

Can you guys please fix this? I don't see why a line ending change that is breaking bash executable support in linux has been an open issue for almost a year now.

[shane-tomlinson]

@mglinski - I understand the frustration, and am sorry for the delay. Unfortunately, you are either going to have to write the patch yourself, convince somebody else to do so for you, wait until somebody else writes the patch, or use a different project. We just don't have the resources to prioritize fixing this.

I'm not going to lie, the folks that originally worked on this project have moved on to other companies. The group that created this project has disbanded, and of those of us that remain, none worked on npm-lockdown. For any of us to fix it, we'd have to read through the code and gain context, just as any external contributor.