setup_environ is now deprecated

[andymckay]

funfactory.manage.setup_environ is now deprecated:

https://docs.djangoproject.com/en/1.4/releases/1.4/#django-core-management-setup-environ

We should use:

https://docs.djangoproject.com/en/1.4/topics/settings/#django.conf.settings.configure

instead or whatever is appropriate.

[peterbe]

Without actualy re-reading some code, I vaguely remember looking into this many many moons ago. Funfactory calls it setup_environ which had the same name as the, now, deprecated django function. However, that the funfactory one does is very different.

[hannson]

I'll keep this brief because I'm in a hurry.

Django 1.6 got released yesterday .The traceback looks like this:

Traceback (most recent call last):
File "manage.py", line 20, in
manage.setup_environ(file, more_pythonic=True)
File "/home/vagrant/project/vendor/src/funfactory/funfactory/manage.py", line 74, in setup_environ

from django.core.management import execute_manager  # noqa

Downgrading to 1.5 which still has the deprecated functions solves the problem for me (for now at least but I might want to upgrade sometime in the near future).

[willkg]

I'm seeing these on the command line:

[localhost] err: /data/input-stage/src/input.allizom.org/input/vendor/lib/python/django/core/management/__init__.py:465: DeprecationWarning: The 'execute_manager' function is deprecated, you likely need to update your 'manage.py'; please see the Django 1.4 release notes (https://docs.djangoproject.com/en/dev/releases/1.4/).
[localhost] err: DeprecationWarning)
[localhost] err: /data/input-stage/src/input.allizom.org/input/vendor/lib/python/django/core/management/__init__.py:409: DeprecationWarning: The 'setup_environ' function is deprecated, you likely need to update your 'manage.py'; please see the Django 1.4 release notes (https://docs.djangoproject.com/en/dev/releases/1.4/).
[localhost] err: DeprecationWarning)

@rlr just fixed this for Kitsune (which is not a playdoh app, but we just updated it to Django 1.5 and it has similar structures).

[rlr]

Actually, I tried to fix it but had to back the fix out because it broke celery (we are on celery 2.5.x). Here was the attempted fix:
mozilla/kitsune@31bf7c8

[willkg]

Oh, right... So this might mean we have to upgrade Celery to something post 2.5 series.

I started doing that a while ago and hit problems, so I did a minor upgrade to the latest in the 2.5 series.