Repository navigation
Conversation
lyzno1
requested review from
aarongarciah,
atomiks,
colmtuite,
flaviendelangle,
jjenzz and
michaldudak
as code owners
October 18, 2026 05:10
commit: |
Bundle size
PerformanceNo regressions in 36 benchmarks · ran 3m 53s · details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
aarongarciah
left a comment
aarongarciah
left a comment
Member
There was a problem hiding this comment.
Thanks! data-nested is accurate. It's only set for submenus (Menu.SubmenuRoot / ContextMenu.SubmenuRoot), not for menus inside other popups.
Could you also document these two attributes that Menu renders but doesn't declare?
data-highlightedonMenu.CheckboxItemIndicatorandMenu.RadioItemIndicatordata-disabledonMenu.RadioGroup. This needs a newMenuRadioGroupDataAttributes.ts, exported from themenuandcontext-menuindexes.
Then rerun pnpm docs:api.
Positioner data-instant is also undocumented, but Popover, Preview Card and Tooltip have the same gap, so can open a separate PR for that.
lyzno1
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Menu renders several data attributes that are missing from their data attribute declarations and API reference.
Menu.PopupandMenu.Positioner:data-nested, present when the menu is a submenu.Menu.CheckboxItemIndicatorandMenu.RadioItemIndicator:data-highlighted.Menu.RadioGroup:data-disabled, via a newMenuRadioGroupDataAttributes, exported from themenuandcontext-menuindexes.Regenerated the Menu and Context Menu API docs with
pnpm docs:api.Positioner
data-instantis also undocumented, but Popover, Preview Card and Tooltip share the same gap, so it will be handled in a separate PR.