Prevent panic when trying to serialize nil pointer in Enum

sfriedel · sfriedel · commit 4c649e36c293 · 2018-07-27T10:30:49.000+02:00
diff --git a/definition.go b/definition.go
@@ -964,7 +964,10 @@ func (gt *Enum) Values() []*EnumValueDefinition {
 }
 func (gt *Enum) Serialize(value interface{}) interface{} {
 	v := value
-	if reflect.ValueOf(v).Kind() == reflect.Ptr {
+	rv := reflect.ValueOf(v)
+	if kind := rv.Kind(); kind == reflect.Ptr && rv.IsNil() {
+		return nil
+	} else if kind == reflect.Ptr {
 		v = reflect.Indirect(reflect.ValueOf(v)).Interface()
 	}
 	if enumValue, ok := gt.getValueLookup()[v]; ok {

Original file line number	Diff line number	Diff line change
`@@ -964,7 +964,10 @@ func (gt Enum) Values() []EnumValueDefinition {`
`964`	`964`	`}`
`965`	`965`	`func (gt *Enum) Serialize(value interface{}) interface{} {`
`966`	`966`	`v := value`
`967`		`- if reflect.ValueOf(v).Kind() == reflect.Ptr {`
	`967`	`+ rv := reflect.ValueOf(v)`
	`968`	`+ if kind := rv.Kind(); kind == reflect.Ptr && rv.IsNil() {`
	`969`	`+ return nil`
	`970`	`+ } else if kind == reflect.Ptr {`
`968`	`971`	`v = reflect.Indirect(reflect.ValueOf(v)).Interface()`
`969`	`972`	`}`
`970`	`973`	`if enumValue, ok := gt.getValueLookup()[v]; ok {`