Sync table with multicodec #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbenet
reviewed
Feb 26, 2017
Member
jbenet
left a comment
jbenet
left a comment
There was a problem hiding this comment.
LGTM. I haven't verified the codes are all right-- do you want me to? (I can)
We should have md5 and the identity hash function (identity = just the same value as the input)
|
If the multihash table is now a subset of the multicodec table, can we remove it here? |
Member
Author
|
@jbenet codes are copied 1:1 from multicodes table and seem to match the implementation on my checks, so I think we ar good there. |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #66,#67