Skip to content

Improve first-run experience for quick filter #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvo5 merged 3 commits into from
Jul 11, 2025
Merged

Improve first-run experience for quick filter #154

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
826aa2a
quick filter: Simplify widget hiding code
DanielG Jul 10, 2025
dcf8269
quick filter: Hide only when apt-xapian-index is unavailable
DanielG Jul 10, 2025
1122a2c
quick filter: Desensitise whole widget while index is updating
DanielG Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions gtk/rgmainwindow.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -894,6 +894,9 @@ gboolean RGMainWindow::xapianDoIndexUpdate(void *data)
gtk_label_set_text(GTK_LABEL(gtk_builder_get_object(me->_builder,
"label_fast_search")),
_("Rebuilding search index"));
gtk_widget_set_sensitive(GTK_WIDGET(gtk_builder_get_object
(me->_builder, "toolbar_filter")), FALSE);

}
return false;
}
Expand All @@ -917,7 +920,7 @@ void RGMainWindow::xapianIndexUpdateFinished(GPid pid, gint status, void* data)
"label_fast_search")),
_("Quick filter"));
gtk_widget_set_sensitive(GTK_WIDGET(gtk_builder_get_object
(me->_builder, "entry_fast_search")), TRUE);
(me->_builder, "toolbar_filter")), TRUE);
g_spawn_close_pid(pid);
}

Expand Down Expand Up @@ -1567,19 +1570,15 @@ void RGMainWindow::buildInterface()

// only enable fast search if its usable
#ifdef HAVE_XAPIAN
if(!_lister->xapiandatabase() ||
!FileExists("/usr/sbin/update-apt-xapian-index")) {
if(!FileExists("/usr/sbin/update-apt-xapian-index"))
#endif
{
gtk_widget_hide(GTK_WIDGET(
gtk_builder_get_object(_builder, "toolitem_fast_search")));
gtk_box_set_center_widget(GTK_BOX(
gtk_builder_get_object(_builder, "hbox_button_toolbar")), NULL);
}
#else
gtk_widget_hide(GTK_WIDGET(
gtk_builder_get_object(_builder, "toolitem_fast_search")));
gtk_box_set_center_widget(GTK_BOX(
gtk_builder_get_object(_builder, "hbox_button_toolbar")), NULL);
#endif

// stuff for the non-root mode
if(getuid() != 0) {
GtkWidget *menu;
Expand Down