feat(forge): Expand forge install error handling (foundry-rs#963)

* Fix .gitignore error in install_as_submodule

* Handle unknown errors in install_as_submodule and install_as_folder

* Run git in quiet mode to stop info messages from going to stderr

* Replace .trim().split() with .lines()

* Remove --quiet flags

* Check exit status instead of stderr str length

* Format

Author: lattejed

cli/src/cmd/install.rs

@@ -102,6 +102,8 @@ fn install_as_folder(dep: &Dependency, libs: &Path) -> eyre::Result<()> {
             "Destination path \"{}\" already exists and is not an empty directory.",
             &dep.name
         )
+    } else if !&output.status.success() {
+        eyre::bail!("{}", stderr.trim())
     }
 
     if let Some(ref tag) = dep.tag {
@@ -141,6 +143,12 @@ fn install_as_submodule(dep: &Dependency, libs: &Path, no_commit: bool) -> eyre:
         )
     } else if stderr.contains("not a git repository") {
         eyre::bail!("\"{}\" is not a git repository", &dep.url)
+    } else if stderr.contains("paths are ignored by one of your .gitignore files") {
+        let error =
+            stderr.lines().filter(|l| !l.starts_with("hint:")).collect::<Vec<&str>>().join("\n");
+        eyre::bail!("{}", error)
+    } else if !&output.status.success() {
+        eyre::bail!("{}", stderr.trim())
     }
 
     // call update on it