Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TIMEOUT_GIVES_CONTROL feature #1588

Open
dominikatrojanowska opened this issue Mar 11, 2025 · 0 comments
Open

Remove TIMEOUT_GIVES_CONTROL feature #1588

dominikatrojanowska opened this issue Mar 11, 2025 · 0 comments

Comments

@dominikatrojanowska
Copy link
Contributor

dominikatrojanowska commented Mar 11, 2025

There is a parameter named: TIMEOUT_GIVES_CONTROL which, if enabled, triggers a timeout (30 seconds) after the control request and. If there has been no deny signal in the meantime, the request is accepted automatically. In the current version of MXCuBE, this feature is disabled by default.

The parameter is set here: https://github.com/mxcube/mxcubeweb/blob/develop/mxcubeweb/app.py#L277
and there is some state and actions related on the frontend: https://github.com/mxcube/mxcubeweb/blob/develop/ui/src/reducers/remoteAccess.js

As discussed: mxcube/mxcubecore#1115 (comment) this feature is going to be removed.

After removal update relevant docs (at least User-based login details.md)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant