Transient spec failure in RequestController

[gbp]

We regularly see CI failures for RequestController if it's test examples are run early in the test run. For example seed 21998

RequestController when listing recent requests F.......

  1) RequestController when listing recent requests sets title based on page
     Failure/Error: raise "Failed to open Xapian database #{@@db_path}: #{e.message}"

     RuntimeError:
       Failed to open Xapian database /home/runner/work/alaveteli/alaveteli/lib/acts_as_xapian/xapiandbs/test: DatabaseNotFoundError: Couldn't stat '/home/runner/work/alaveteli/alaveteli/lib/acts_as_xapian/xapiandbs/test' (No such file or directory)
     # ./lib/acts_as_xapian/acts_as_xapian.rb:180:in `rescue in readable_init'
     # ./lib/acts_as_xapian/acts_as_xapian.rb:176:in `readable_init'
     # ./lib/acts_as_xapian/acts_as_xapian.rb:328:in `initialize_db'
     # ./lib/acts_as_xapian/acts_as_xapian.rb:521:in `initialize'
     # ./app/models/info_request.rb:1840:in `new'
     # ./app/models/info_request.rb:1840:in `search_events'
     # ./app/models/info_request.rb:609:in `request_list'
     # ./app/controllers/request_controller.rb:139:in `list'
     # ./app/controllers/application_controller.rb:131:in `record_memory'
     # ./spec/controllers/request_controller_spec.rb:49:in `block (2 levels) in <top (required)>'
     # ------------------
     # --- Caused by: ---
     # IOError:
     #   DatabaseNotFoundError: Couldn't stat '/home/runner/work/alaveteli/alaveteli/lib/acts_as_xapian/xapiandbs/test' (No such file or directory)
     #   ./lib/acts_as_xapian/acts_as_xapian.rb:177:in `initialize'

[gbp]

This should be a straightforward fix. Simply call update_xapian_index in a before each block should be enough