Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include documentation in index.d.ts #19

Open
RunDevelopment opened this issue Nov 17, 2020 · 1 comment · Fixed by eslint-community/regexpp#67
Open

Include documentation in index.d.ts #19

RunDevelopment opened this issue Nov 17, 2020 · 1 comment · Fixed by eslint-community/regexpp#67

Comments

@RunDevelopment
Copy link

I noticed that index.d.ts doesn't include any documentation even though a lot of useful comments are defined in the source files. Having inline documentation in your IDE of choice is very useful, so could it please be added in the next release?

The only thing that has to changed for this is the removeComments definition. This means that comments will also be included in the JS files, but that shouldn't be an issue since they aren't minified anyway.

Should I make a PR?

@MichaelDeBoey
Copy link

MichaelDeBoey commented Oct 14, 2023

For people watching this issue: we've already started with our own fork in order to not hold the wider community back anymore: https://github.com/eslint-community/regexpp

@mysticatea We would still love to move the original repo to the new @eslint-community though.


This PR is released in @eslint-community/regexpp v4.5.0
https://github.com/eslint-community/regexpp/releases/tag/v4.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants