Skip to content

netcheck: Implement https probe #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flub opened this issue Jul 12, 2023 · 4 comments
Closed

netcheck: Implement https probe #1218

flub opened this issue Jul 12, 2023 · 4 comments

Comments

@flub
Copy link
Contributor

flub commented Jul 12, 2023

The https probe is currently included in the probeplan and executed, but it is not implemented either as a probe nor in the derper. Both need to be implemented.

@flub flub added this to iroh Jul 12, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog - unassigned issues in iroh Jul 12, 2023
@dignifiedquire dignifiedquire added this to the v0.5.1 milestone Jul 18, 2023
@b5 b5 modified the milestones: v0.6.0-alpha: Sync!, v0.6.1 Aug 24, 2023
@b5 b5 modified the milestones: v0.6.0, v0.7.0 Sep 14, 2023
@b5 b5 removed this from the v0.7.0 milestone Sep 26, 2023
@flub
Copy link
Contributor Author

flub commented Oct 10, 2024

https://github.com/n0-computer/iroh/tree/flub/https-probe is a branch where this was implemented fairly fully. It stalled on something silly, I think tests (which now should be possible - there is testing infra to run an entire relay server in a unittest now). It probably can't be merged immediately because so much has changed, but hopefully a lot of it can be used.

@matheus23
Copy link
Member

This is necessary work for #2799

@matheus23
Copy link
Member

@flub can this be closed now that #2903 landed?

@flub
Copy link
Contributor Author

flub commented Nov 12, 2024

yes!

@flub flub closed this as completed Nov 12, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in iroh Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants