From 2d390a0d6fa2b2120eafb50a8a323c659220b6f8 Mon Sep 17 00:00:00 2001 From: Scott Nichols Date: Sun, 1 Mar 2026 09:21:08 -0800 Subject: [PATCH] dim the done labels --- .../components/collectiondetail/model_test.go | 16 ++++++++++++++++ pkg/tui/components/collectiondetail/view.go | 1 + .../components/collectiondetail2/model_test.go | 16 ++++++++++++++++ pkg/tui/components/collectiondetail2/view.go | 1 + 4 files changed, 34 insertions(+) diff --git a/pkg/tui/components/collectiondetail/model_test.go b/pkg/tui/components/collectiondetail/model_test.go index 18f1f49..28960c3 100644 --- a/pkg/tui/components/collectiondetail/model_test.go +++ b/pkg/tui/components/collectiondetail/model_test.go @@ -205,3 +205,19 @@ func TestViewRendersLabelsBeneathBullet(t *testing.T) { t.Fatalf("expected labels prefix to be removed, got:\n%s", view) } } + +func TestCompletedBulletsDimLabelsStyle(t *testing.T) { + model := NewModel(nil) + + _, _, labelsStyle := model.bulletStyles(Bullet{Bullet: glyph.Task}) + normalRendered := labelsStyle.Render("owner:codex") + if !strings.Contains(normalRendered, "38;5;214m") { + t.Fatalf("expected active labels to render mustard, got: %q", normalRendered) + } + + _, _, labelsStyle = model.bulletStyles(Bullet{Bullet: glyph.Completed}) + completedRendered := labelsStyle.Render("owner:codex") + if !strings.Contains(completedRendered, "38;5;241m") { + t.Fatalf("expected completed labels to render dim gray, got: %q", completedRendered) + } +} diff --git a/pkg/tui/components/collectiondetail/view.go b/pkg/tui/components/collectiondetail/view.go index 3315212..0dca968 100644 --- a/pkg/tui/components/collectiondetail/view.go +++ b/pkg/tui/components/collectiondetail/view.go @@ -218,6 +218,7 @@ func (m *Model) bulletStyles(item Bullet) (lipgloss.Style, lipgloss.Style, lipgl case glyph.Completed, glyph.Irrelevant, glyph.MovedCollection, glyph.MovedFuture: prefixStyle = prefixStyle.Foreground(lipgloss.Color("241")) messageStyle = messageStyle.Foreground(lipgloss.Color("241")) + labelsStyle = labelsStyle.Foreground(lipgloss.Color("241")) } if item.Bullet == glyph.Irrelevant { messageStyle = messageStyle.Strikethrough(true) diff --git a/pkg/tui/components/collectiondetail2/model_test.go b/pkg/tui/components/collectiondetail2/model_test.go index 10cc79b..c1aceda 100644 --- a/pkg/tui/components/collectiondetail2/model_test.go +++ b/pkg/tui/components/collectiondetail2/model_test.go @@ -300,3 +300,19 @@ func TestViewRendersLabelsBeneathBullet(t *testing.T) { t.Fatalf("expected labels prefix to be removed, got:\n%s", view) } } + +func TestCompletedBulletsDimLabelsStyle(t *testing.T) { + model := NewModel(nil) + + _, _, labelsStyle := model.bulletStyles(Bullet{Bullet: glyph.Task}) + normalRendered := labelsStyle.Render("owner:codex") + if !strings.Contains(normalRendered, "38;5;214m") { + t.Fatalf("expected active labels to render mustard, got: %q", normalRendered) + } + + _, _, labelsStyle = model.bulletStyles(Bullet{Bullet: glyph.Completed}) + completedRendered := labelsStyle.Render("owner:codex") + if !strings.Contains(completedRendered, "38;5;241m") { + t.Fatalf("expected completed labels to render dim gray, got: %q", completedRendered) + } +} diff --git a/pkg/tui/components/collectiondetail2/view.go b/pkg/tui/components/collectiondetail2/view.go index a78b8d4..3b686b4 100644 --- a/pkg/tui/components/collectiondetail2/view.go +++ b/pkg/tui/components/collectiondetail2/view.go @@ -225,6 +225,7 @@ func (m *Model) bulletStyles(item Bullet) (lipgloss.Style, lipgloss.Style, lipgl case glyph.Completed, glyph.Irrelevant, glyph.MovedCollection, glyph.MovedFuture: prefixStyle = prefixStyle.Foreground(lipgloss.Color("241")) messageStyle = messageStyle.Foreground(lipgloss.Color("241")) + labelsStyle = labelsStyle.Foreground(lipgloss.Color("241")) } if item.Bullet == glyph.Irrelevant { messageStyle = messageStyle.Strikethrough(true)