Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Julia 1.0 #27

Closed
bkamins opened this issue Aug 25, 2018 · 7 comments
Closed

Update to Julia 1.0 #27

bkamins opened this issue Aug 25, 2018 · 7 comments

Comments

@bkamins
Copy link
Collaborator

bkamins commented Aug 25, 2018

@nalimilan I do not want to start pushing PRs migrating this package to Julia 1.0, before I understand your plans regarding this. Most of things that fail should be fixable by femtocleaner I guess (and NamedArrays on master are ready/almost ready for Julia 1.0).

Please let me know how you want to proceed and how I could help (I really like this package 😄).

@nalimilan
Copy link
Owner

Please feel free to go ahead and do anything necessary to get the tests to pass on 1.0. Hopefully Femtocleaner will do most of the work.

@bkamins
Copy link
Collaborator Author

bkamins commented Aug 26, 2018

Yes, but I guess it is you who should initiate Femtocleaner on the repo? Or I am missing something?

@nalimilan
Copy link
Owner

AFAICT it's enabled already?

@bkamins
Copy link
Collaborator Author

bkamins commented Aug 26, 2018

But I saw in DataFramesMeta.jl that Femtocleaner automatically created a PR. Do you know how to trigger this? Then I would review what would be left broken.

@nalimilan
Copy link
Owner

You just have to bump the minimum Julia version in REQUIRES and open a PR, and it should clean everything it can.

@bkamins
Copy link
Collaborator Author

bkamins commented Aug 26, 2018

OK. I will do it when NamedArrays are tagged with a new release.

@nalimilan
Copy link
Owner

See #28 for a first step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants