-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Julia 1.0 #27
Comments
Please feel free to go ahead and do anything necessary to get the tests to pass on 1.0. Hopefully Femtocleaner will do most of the work. |
Yes, but I guess it is you who should initiate Femtocleaner on the repo? Or I am missing something? |
AFAICT it's enabled already? |
But I saw in |
You just have to bump the minimum Julia version in REQUIRES and open a PR, and it should clean everything it can. |
OK. I will do it when |
See #28 for a first step. |
@nalimilan I do not want to start pushing PRs migrating this package to Julia 1.0, before I understand your plans regarding this. Most of things that fail should be fixable by femtocleaner I guess (and
NamedArrays
on master are ready/almost ready for Julia 1.0).Please let me know how you want to proceed and how I could help (I really like this package 😄).
The text was updated successfully, but these errors were encountered: