Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reexport Name from NamedArrays #31

Open
bkamins opened this issue Sep 5, 2018 · 2 comments
Open

Reexport Name from NamedArrays #31

bkamins opened this issue Sep 5, 2018 · 2 comments

Comments

@bkamins
Copy link
Collaborator

bkamins commented Sep 5, 2018

I think we should reexport Name from NamedArrays in this package?

@nalimilan
Copy link
Owner

Tough question. In general I'd tend to reexport a full package rather than individual functions. NamedArrays is kind of special since you can use them a lot while only calling Base functions, but it's API is also small so reexporting everything wouldn't be too bad.

Finally, another consideration is that we could have the objective of including FreqTables and NamedArrays in Stats.jl, in which case it would make sense to keep FreqTables limited in the functionality it exports.

@bkamins
Copy link
Collaborator Author

bkamins commented Sep 5, 2018

We can keep it open now (I am OK with any decision you make - just wanted to highlight the issue).
The problem, as probably you are aware, is that now you have to do using NamedArrays to index into an array using integers as names (which is pretty common) so it is not enormously bad (but inconvenient).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants