Merge branch 'nanoframework:develop' into develop

Author: edleno2

NuGet.Config

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <configuration>
     <packageSources>
-        <add key="NuGet" value="https://api.nuget.org/v3/index.json" protocolVersion="3" />
         <add key="Azure Artifacts nanoFramework dev" value="https://pkgs.dev.azure.com/nanoframework/feed/_packaging/sandbox/nuget/v3/index.json" protocolVersion="3" />
+        <add key="NuGet" value="https://api.nuget.org/v3/index.json" protocolVersion="3" />
     </packageSources>
 </configuration>

README.md

@@ -22,11 +22,11 @@ The .NET **nanoFramework** Base Class Library is provided in two flavours: with
 
 ## Unit Test
 
-nanoFramework has a dedicated [Unit Test framework](https://github.com/nanoframework/nanoFramework.TestFramework). This repository has Unit Test and you will find all of them under the `Tests`folder. The main solution embed all all the tests as well. You can run them directly from Visual Studio and create new tests. For more information on the [Unit Test Framework](https://docs.nanoframework.net/content/unit-test/index.html).
+nanoFramework has a dedicated [Unit Test framework](https://github.com/nanoframework/nanoFramework.TestFramework). This repository has Unit Test and you will find all of them under the `Tests` folder. The main solution embed all all the tests as well. You can run them directly from Visual Studio and create new tests. For more information on the [Unit Test Framework](https://docs.nanoframework.net/content/unit-test/index.html).
 
 CoreLibrary has specific needs that differ from what you'll find in the documentation:
 
-- You need to have th nanoFramework.TestFramework as a nuget package as it will bring the nanoCLR Win32 emulator
+- You need to have the nanoFramework.TestFramework as a nuget package as it will bring the nanoCLR Win32 emulator
 - You need to remove the reference to mscorlib, nanoFramework.TestFramework and nanoFramework.UnitTestLauncher
 - Use project reference instead for all those 3 elements
 

azure-pipelines.yml

@@ -76,9 +76,9 @@ jobs:
 
   - template: azure-pipelines-templates/class-lib-publish.yml@templates  
 
-  # need to push the other package to NuGet because the template above can only push one package (happens on tag builds for any branch)
+  # need to push the other package to NuGet because the template above can only push one package (happens on all builds except PRs)
   - task: NuGetCommand@2
-    condition: and( succeeded(), eq( variables['StartReleaseCandidate'], false ) )
+    condition: and( succeeded(), eq(variables['System.PullRequest.PullRequestId'], ''), eq( variables['StartReleaseCandidate'], false ) )
     displayName: Push "NoReflection" variant NuGet package to Azure Artifacts
     inputs:
       command: push
@@ -152,18 +152,14 @@ jobs:
     vmImage: 'windows-2019'
 
   variables:
-    DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true
+    DOTNET_NOLOGO: true
 
   steps:
   # need this here in order to persist GitHub credentials 
   - checkout: self
     fetchDepth: 1
 
-  - task: NuGetToolInstaller@0
-    inputs:
-      versionSpec: '5.9.0'
-    condition: ne( variables['StartReleaseCandidate'], true )
-    displayName: 'Install specific version of NuGet'
+  - template: azure-pipelines-templates/install-nuget.yml@templates
 
   # update dependents
   - task: UpdatenFDependencies@1
@@ -172,25 +168,25 @@ jobs:
       repositoriesToUpdate: |
         nanoFramework.Runtime.Events
         nanoFramework.Runtime.Native
-        nanoFramework.System.Threading
         nanoFramework.TestFramework
         nanoFramework.Logging
+        nanoFramework.Devices.OneWire
+        nanoFramework.Networking.Sntp
+        nanoFramework.Hardware.Stm32
+        nanoFramework.TI.EasyLink
+        nanoFramework.ResourceManager
+        nanoFramework.Json
         Windows.Devices.Adc
         Windows.Devices.I2c
         Windows.Devices.Pwm
         Windows.Devices.Spi
         System.Device.Dac
         System.Device.I2c
         System.Device.Spi
-        nanoFramework.Devices.OneWire
-        nanoFramework.Networking.Sntp
-        nanoFramework.Hardware.Stm32
-        nanoFramework.System.Math
-        nanoFramework.TI.EasyLink
-        nanoFramework.ResourceManager
-        nanoFramework.System.Collections
-        nanoFramework.System.Text
-        nanoFramework.Json
+        System.Threading
+        System.Math
+        System.Collections
+        System.Text
     displayName: Update dependent class libs
 
 ##################################

nanoFramework.CoreLibrary.DELIVERABLES.nuspec

@@ -11,7 +11,7 @@
     <releaseNotes></releaseNotes>
     <developmentDependency>false</developmentDependency>
     <projectUrl>https://github.com/nanoframework/CoreLibrary</projectUrl>
-    <icon>nf-logo.png</icon>
+    <icon>images\nf-logo.png</icon>
     <copyright>Copyright (c) .NET Foundation and Contributors</copyright>    
     <description>** DON'T REFERENCE THIS PACKAGE ** Not meant for development. This package includes the deliverable artifacts of the base class library (mscorlib) of nanoFramework. These are for testing purposes and for updating the native code base of the core library.</description>
     <tags></tags>
@@ -25,7 +25,7 @@
     <file src="nanoFramework.CoreLibrary\obj\Release\*.il" target="content\disasm\" /> 
 
     <file src="assets\readme.txt" target="" />
-    <file src="assets\nf-logo.png" target="" />
+    <file src="assets\nf-logo.png" target="images" />
     <file src="LICENSE.md" target="" />
   </files>
 </package>