Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

Better tab title matching #67

Open
nareddyt opened this issue May 4, 2018 · 3 comments
Open

Better tab title matching #67

nareddyt opened this issue May 4, 2018 · 3 comments
Labels
enhancement New feature or request good first issue Good for beginners help wanted Extra attention is needed

Comments

@nareddyt
Copy link
Owner

nareddyt commented May 4, 2018

In #66, we introduced a new way to determine which offers should appear on a webpage. Specifically, we now fallback to checking the title of the tab and trying to match that to a retailer name in the data files.

For example, when I google for j. crew, the following appears because the tab name has j. crew in it:

image

However, this doesn't work if I google for j.crew or j crew because our matching algorithm just does a ignorecase string match.

We should add support for the following string match algorithms:

  • Ignore whitespace
  • Ignore punctuation
  • Ignore whole worlds. For example, I need to search for American Eagle Outfitters instead of just American Eagle. This is a harder problem, so this doesn't need to be solved yet.
  • Ignore special characters, like the trademark symbol.

Also, we should also try to match the tab title against the hostname. That way, if I search for ae in google, it gives me a deal for American Eagle because the site url is www.ae.com.

@nareddyt nareddyt added enhancement New feature or request help wanted Extra attention is needed good first issue Good for beginners labels May 4, 2018
@nareddyt
Copy link
Owner Author

nareddyt commented May 5, 2018

See #70 for another example of bad title matching. In #70's case, we were not strict enough and were matching anything, even if it wasn't a full word.

@itsthecheat
Copy link

Hey @nareddyt , would love to work on this

@nareddyt
Copy link
Owner Author

Go ahead! Let me know if you have any questions

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for beginners help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants