Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package size is quite big #81

Closed
Siilwyn opened this issue Jan 6, 2021 · 2 comments
Closed

Package size is quite big #81

Siilwyn opened this issue Jan 6, 2021 · 2 comments
Milestone
v1.1.0

Comments

@Siilwyn
Copy link

Siilwyn commented Jan 6, 2021 •
edited
Loading

The package install size 160 MB. Reducing the size will help install speed and save some bandwidth.

Perhaps there are lighter alternatives that can achieve the same, or maybe some dependencies are only development dependencies?

The biggest packages when I install microsite locally on Linux:
image
@natemoo-re
Copy link
Owner

Thank you! I really appreciate issues like this. I will absolutely be focusing on reducing the Microsite's installation footprint.

  • There's no (good) reason for prettier to be in there, I can remove that easily
  • Users should be prompted to install postcss locally, similar to Next.js

Honestly I think that will take most of the packages in this list out of the equation.

natemoo-re added a commit that referenced this issue Jan 20, 2021
@natemoo-re
fix(#81): remove PostCSS from core dependencies
c39f8c3
natemoo-re added a commit that referenced this issue Jan 20, 2021
@natemoo-re
fix(#81): remove prettier from core dependencies
1e65bd8
@natemoo-re natemoo-re added this to the v1.1.0 milestone Jan 20, 2021
@natemoo-re
Copy link
Owner

natemoo-re commented Jan 20, 2021 •
edited
Loading

Here is the packagephobia report on the old dependencies, and the packagephobia report on the new dependencies.

I removed the following direct dependencies in v1.1.0 (see #94), which should also remove most of the nested dependencies from your screenshot:

  • prettier 8.66MB
  • postcss-preset-env 6.45MB
  • postcss-cli 2.62MB
  • postcss 1.03MB
  • @snowpack/plugin-postcss 246kB
  • postcss-flexbugs-fixes 9.18kB
  • Total 19.02MB

This is something I'll be paying more attention to moving forward. Currently Microsite is just compiled with tsc, but I'm sure using Rollup to bundle and treeshake would help significantly. Once that's setup I can probably cut down the dependencies to snowpack and preact.

I'm going to close this and track future improvements in #95.

@natemoo-re natemoo-re mentioned this issue Jan 20, 2021
Open
natemoo-re added a commit that referenced this issue Jan 23, 2021
@natemoo-re
fix(#81): remove PostCSS from core dependencies
1eb8733
natemoo-re added a commit that referenced this issue Jan 23, 2021
@natemoo-re
fix(#81): remove prettier from core dependencies
669eab2
natemoo-re added a commit that referenced this issue Jan 29, 2021
@natemoo-re
fix(#81): remove PostCSS from core dependencies
b792105
natemoo-re added a commit that referenced this issue Jan 29, 2021
@natemoo-re
fix(#81): remove prettier from core dependencies
344a63d
natemoo-re added a commit that referenced this issue Feb 22, 2021
@natemoo-re
fix(#81): remove PostCSS from core dependencies
b0c3a33
natemoo-re added a commit that referenced this issue Feb 22, 2021
@natemoo-re
fix(#81): remove prettier from core dependencies
04f7dd8
natemoo-re added a commit that referenced this issue Feb 24, 2021
@natemoo-re
fix(#81): remove PostCSS from core dependencies
ed93087
natemoo-re added a commit that referenced this issue Feb 24, 2021
@natemoo-re
fix(#81): remove prettier from core dependencies
ac5c1d2
natemoo-re added a commit that referenced this issue Mar 3, 2021
@natemoo-re
fix(#81): remove PostCSS from core dependencies
b460abb
natemoo-re added a commit that referenced this issue Mar 3, 2021
@natemoo-re
fix(#81): remove prettier from core dependencies
1ec546d
natemoo-re added a commit that referenced this issue Mar 19, 2021
@natemoo-re
fix(#81): remove PostCSS from core dependencies
4566499
natemoo-re added a commit that referenced this issue Mar 19, 2021
@natemoo-re
fix(#81): remove prettier from core dependencies
c2f55fe
natemoo-re added a commit that referenced this issue Mar 19, 2021
@natemoo-re @eyelidlessness @sprabowo
v1.1.0 (#94)
0c9d426 
* wip: [email protected] changes

* fix: remove custom document logic from dev

* wip: remap [email protected] default output directories

* fix(#81): remove PostCSS from core dependencies

* fix(#81): remove prettier from core dependencies

* fix(83): exclude image/font MIME types from transform

* fix(dev): implements a few more [email protected] changes

* Ensure shared hydration chunks are included in build (#105)

Also include updated package-lock.json based on instructions in https://github.com/natemoo-re/microsite/blob/1853843192cb9e0baa8ff93f872cb595a64fbe7f/.github/CONTRIBUTING.md

* Ensure head is rendered for SSG

It seems the implementation was intended to achieve this sort of isolation the same way `docContext` is used. But the `useRef` version was basically just sending any children in `Head` into the memory hole on build.

* Add another page just to validate that each page gets a new head context as expected

* chore: changeset

* chore: release 1.1.0-next.4

* Fix an issue with binary public file corruption (#110)

* Ensure head is rendered for SSG

It seems the implementation was intended to achieve this sort of isolation the same way `docContext` is used. But the `useRef` version was basically just sending any children in `Head` into the memory hole on build.

* Add another page just to validate that each page gets a new head context as expected

* Fix an issue with binary public file corruption

The previous behavior was reading binary files as strings, which was corrupting them on output

* fix: missed rebase issue

* fix: properly resolve example script in CI

* fix: remove assumption that code lives in "node_modules"

* fix(examples): prefer readFile to fetch

* fix: pin preact to 10.5.10

* fix: pin snowpack to 3.0.x

* chore: changeset

* chore: v1.1.0-next.5

* chore: fixup package-locks

* chore: fixup package-lock files

* chore: ignore logfiles

* Fix requestIdleCallback logic (#112)

* fix(#111): hydration failure in safari

* chore: update package lock

* fix(#111): use requestIdleCallback shim

* chore: changeset

* fix: update createPersistentFragment for [email protected]+

* chore: changeset

* chore: v1.1.0-next.6

* chore: bump package-lock

* chore: update example locks

* fix(#119): remove `defer` from inline script

* Omit base tag by default (#117)

* Omit base tag by default

* Ensure resources are prefixed with `/` when base tag is omitted

* Lol whoops I meant to remove this

* fix(#115): do not include vendor chunk in hydrateBindings

* chore: publish [email protected]

* chore: add changeset

* chore: v1.1.0-next.7

* chore(deps): [email protected]

* fix(#125): prefer pinned Skypack URLs

* chore: remove debug

* chore: changeset

* chore: 1.1.0-next.8

* WIP: dev ssr (#113)

* fix(dev): implements a few more [email protected] changes

* Ensure shared hydration chunks are included in build (#105)

Also include updated package-lock.json based on instructions in https://github.com/natemoo-re/microsite/blob/1853843192cb9e0baa8ff93f872cb595a64fbe7f/.github/CONTRIBUTING.md

* chore: fixup package-locks

* chore: fixup package-lock files

* chore: update example locks

* WIP: dev ssr

* WIP: dev ssr getStaticProps/Paths

* feat: add proper error page handling in dev mode

* chore(examples): update deps

* feat: finalize dev SSR support

* chore(examples): add CSS-in-JS examples

* chore(examples): update goober example

* fix: cleanup deps

Co-authored-by: eyelidlessness <[email protected]>

* fix(#126): emit shared css modules (#127)

* chore: v1.1.0-next.9

* chore: remove package-locks?

* fix: shared CSS module logic

* chore: 1.1.0-next.10

* feat(hydration): add "fallback" prop to "withHydrate"

* fix: global chunk loading

* chore(examples): add custom ssr fallback example

* chore: v1.1.0-next.11

* Add benchmark action (#129)

* feat: add gzip/brotli to benchmark

* chore(action): add benchmark test action

* chore(action): test benchmark

* chore(action): test benchmark

* chore(action): update benchmark filter

* chore(action): update benchmark scripts

* chore: revert lockfile to v1

* chore(action): update benchmark script

* chore(action): update benchmark script

* chore(action): update benchmark action

* chore(action): update benchmark script

* chore(action): update benchmark script

* chore(action): update benchmark script

* chore(action): update benchmark script

* chore(action): update benchmark script

* chore(action): add context to benchmark message

* chore(action): update benchmark to 15 runs

* chore(action): require manual trigger for benchmark action

* chore(action): fixup benchmark script

* chore(action): add commit to benchmark action

* chore(action): fix workflow_dispatch

* docs: update benchmark

* chore: update benchmark table formatting

* chore(bench): restructure benchmarks

* chore(bench): add counter example

* chore(bench): add lighthouse scores to benchmark

* chore(bench): run benchmarks

* chore(bench): update size label

* Fix preact import regex matching other things (#135)

* docs: fix wrong variable, update css in js context (#131)

* doc: fix wrong variable name

* doc: fix file naming, since it doesn't render jsx

* doc: adding with-fela and with-goober example

* update without .md extension

* Update styling.md

* Fix preact import regex matching other things

Currently preact import regex matches other things (e.g @mdx-js/preact).

* Escape forward slashes

Co-authored-by: Sigit Prabowo <[email protected]>
Co-authored-by: Nate Moore <[email protected]>

* Fix incorrect field used for aliases from snowpack user config (#136)

* docs: fix wrong variable, update css in js context (#131)

* doc: fix wrong variable name

* doc: fix file naming, since it doesn't render jsx

* doc: adding with-fela and with-goober example

* update without .md extension

* Update styling.md

* Fix aliases from userConfig not being loaded

Co-authored-by: Sigit Prabowo <[email protected]>
Co-authored-by: Nate Moore <[email protected]>

* Ensure nested imports are hydrated, allow optional display name override for named exports (#140)

* final changes for v1.1.0

Co-authored-by: eyelidlessness <[email protected]>
Co-authored-by: eyelidlessness <[email protected]>
Co-authored-by: Reeto Chatterjee <[email protected]>
Co-authored-by: Sigit Prabowo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
2 participants
@Siilwyn @natemoo-re