Skip to content

Commit 57ca0b2

Browse files
committed
fix(ios): revert last changes and fixed it the right way
1 parent 73a8562 commit 57ca0b2

File tree

5 files changed

+9
-0
lines changed

5 files changed

+9
-0
lines changed

packages/gesturehandler/platforms/ios/src/GestureHandlerManager.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
- (void)updateGestureHandler:(nonnull NSNumber *)handlerTag config:(nonnull NSDictionary *)config;
1717

1818
- (void)dropGestureHandler:(nonnull NSNumber *)handlerTag;
19+
- (void)registerGestureHandler:(nonnull GestureHandler *)gestureHandler;
1920

2021
//- (void)handleSetJSResponder:(nonnull UIView *)view
2122
// blockNativeResponder:(nonnull NSNumber *)blockNativeResponder;

packages/gesturehandler/platforms/ios/src/GestureHandlerManager.m

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,10 @@ - (GestureHandler*)createGestureHandler:(NSString *)handlerName
6868
}
6969

7070

71+
- (void)registerGestureHandler:(nonnull GestureHandler *)gestureHandler
72+
{
73+
[_registry registerGestureHandler:gestureHandler];
74+
}
7175
- (void)attachGestureHandler:(nonnull NSNumber *)handlerTag
7276
toView:(nonnull UIView *)view
7377
{

packages/gesturehandler/platforms/ios/src/GestureHandlerRegistry.m

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,9 @@ - (GestureHandler *)handlerWithTag:(NSNumber *)handlerTag
2828

2929
- (void)registerGestureHandler:(GestureHandler *)gestureHandler
3030
{
31+
if ([_handlers objectForKey:gestureHandler.tag] == nil) {
3132
_handlers[gestureHandler.tag] = gestureHandler;
33+
}
3234
}
3335

3436
- (void)attachHandlerWithTag:(NSNumber *)handlerTag toView:(UIView *)view

src/gesturehandler/gesturehandler.ios.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -254,6 +254,7 @@ export class Manager extends ManagerBase {
254254

255255
viewListeners = new Map<View, Map<number, { init: () => void; dispose: () => void }>>();
256256
attachGestureHandler(handler: Handler<any, any>, view: View) {
257+
this.manager.registerGestureHandler(handler.native);
257258
const tag = handler.native.tag;
258259
if (view.nativeView) {
259260
this.manager.attachGestureHandlerToView(tag, view[handler.nativeGetterKey]);

src/gesturehandler/typings/ios.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,7 @@ declare class GestureHandlerManager extends NSObject {
157157
createGestureHandlerTagConfig(handlerName: string, handlerTag: number, config: NSDictionary<any, any>): GestureHandler;
158158

159159
dropGestureHandler(handlerTag: number): void;
160+
registerGestureHandler(handler: GestureHandler): void;
160161

161162
updateGestureHandlerConfig(handlerTag: number, config: NSDictionary<any, any>): void;
162163
}

0 commit comments

Comments
 (0)