Skip to content

Commit f0a4b88

Browse files
authored
Merge pull request #51 from nativescript-community/fix/vue-parent-destroy-bug
fix(vue): properly dispose vnodes
2 parents 09fdc49 + 8ecfc4a commit f0a4b88

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/collectionview/vue/component.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,9 @@ export default {
7979
},
8080
onItemDisposingInternal(args) {
8181
const oldVnode = args.view && args.view[VUE_VIEW];
82-
if (oldVnode && oldVnode.componentInstance) {
83-
oldVnode.componentInstance.$destroy();
84-
args.view[VUE_VIEW] = null;
82+
if (oldVnode) {
83+
// properly dispose the oldVnode (this will unmount the tree)
84+
this.__patch__(oldVnode, null);
8585
}
8686
},
8787
refresh() {

0 commit comments

Comments
 (0)