json: true sends "true" as request body no matter what

[bjoerge]

xhr({body: {foo: 'bar'}, json: true})

will post true as request body.

It even sends false as request body if passing json: false.

According to request docs, the json flag is only used as a modifier to body:

json - sets body to JSON representation of value and adds Content-type: application/json header. Additionally, parses the response body as JSON.
(https://github.com/request/request/blob/master/README.md#requestoptions-callback)

[wesleytodd]

Hey, sorry if this is late to the party, or if I missed anything somewhere in #136, but it seems to me like this not working is a bug in the current branch that can be fixed before a major version bump. Something like this could fix it until #135 goes through:

body = JSON.stringify(options.json === true ? body : options.json)

This bug blocks a bunch of legitimate use cases (body-less DELETE requests which expect json back, for example) in the 2.0 branch, and so I think holding up a release here is a mistake, but that is just my personal opinion.

I can submit the PR for this if it seems like a good change

[naugtur]

Very good point. Would you by any chance like to contribute a testcase for that?

I'll look into it more tomorrow.

[naugtur]

Done, #139

[wesleytodd]

Looks like you have it all covered? Let me know if you need anything else to help out! Otherwise good work!!

[naugtur]

merged, releasing 2.3.0