Skip to content

"Plans awaiting review" KPI points users at the Review console, which only handles wiki drafts (not compilation plans) #33

Description

@apjaphet

Summary

The Dashboard Overview shows a "Plans awaiting review" KPI (e.g. "2"), but the Review console (/wiki/review) shows an empty queue. Users reasonably click through expecting to action those plans and find nothing.

Root cause

These are two unrelated review concepts that both use the word "review":

  • "Plans awaiting review" = source_compilation_plans rows with status = 'pending_review' (counted in app/services/stats_aggregator.py as compile_plan.pending_review). These are actioned in the plan-review dialog on the Knowledge table (frontend/src/components/knowledge/knowledge-table/plan-review-dialog.tsx).
  • The Review console (frontend/src/app/(portal)/wiki/review/page.tsx) only loads wiki contribution branches/drafts via /api/wiki/branches. With zero pending drafts, its queue is empty — it never shows compilation plans.

So both numbers are individually correct; the problem is that the KPI implies a destination that doesn't handle plans.

Impact

Pure UX/navigation confusion — no data corruption. But it makes the pending-plans count look broken/unreachable.

Suggested fix (not done)

Either:

  1. Link the "Plans awaiting review" KPI to the Knowledge table filtered to pending_review plans (where they're actually actioned), or
  2. Add a compilation-plans tab/section to the Review console so "review" is a single destination, or
  3. Rename the KPI to disambiguate (e.g. "Source plans awaiting review") and point it at the correct screen.

Recommend option 1 as the smallest change.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions