update the default dir setup logic to make it more homebrew friendly

Author: neel1996

.gitignore

@@ -7,3 +7,5 @@ env_config.json
 gitclient
 /*.exe
 /*.dll
+gitconvex
+gitconvex-server

generators/default_dir_const_gen.go

@@ -0,0 +1,28 @@
+package main
+
+import (
+	"fmt"
+	"log"
+	"os"
+	"text/template"
+)
+
+func main() {
+	templateString := fmt.Sprintf("package global\n\nfunc GetDefaultDirectory() string {\n\treturn \"{{ .DefaultDirFromEnv }}\"\n}\n")
+	var fileTemplate = template.Must(template.New("").Parse(templateString))
+
+	var defaultDirFromEnv = os.Getenv("GITCONVEX_DEFAULT_PATH")
+	file, fileErr := os.Create("./global/default_dir_const.go")
+	if fileErr != nil {
+		log.Fatal(fileErr.Error())
+	}
+
+	err := fileTemplate.ExecuteTemplate(file, "", struct {
+		DefaultDirFromEnv string
+	}{
+		DefaultDirFromEnv: defaultDirFromEnv,
+	})
+	if err != nil {
+		log.Fatal(err.Error())
+	}
+}

global/default_dir_const.go

@@ -0,0 +1,5 @@
+package global
+
+func GetDefaultDirectory() string {
+	return "GENERATED_ENV_STRING_GOES_HERE"
+}

go.mod

@@ -9,7 +9,7 @@ require (
 	github.com/libgit2/git2go/v31 v31.4.10
 	github.com/rs/cors v1.7.0
 	github.com/sirupsen/logrus v1.8.1
-	github.com/stretchr/testify v1.4.0
+	github.com/stretchr/testify v1.7.0
 	github.com/vektah/gqlparser/v2 v2.1.0
 	golang.org/x/crypto v0.0.0-20201203163018-be400aefbc4c
 )

go.sum

@@ -61,8 +61,9 @@ github.com/sirupsen/logrus v1.8.1/go.mod h1:yWOB1SBYBC5VeMP7gHvWumXLIWorT60ONWic
 github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
 github.com/stretchr/testify v1.2.1/go.mod h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXfy6kDkUVs=
 github.com/stretchr/testify v1.2.2/go.mod h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXfy6kDkUVs=
-github.com/stretchr/testify v1.4.0 h1:2E4SXV/wtOkTonXsotYi4li6zVWxYlZuYNCXe9XRJyk=
 github.com/stretchr/testify v1.4.0/go.mod h1:j7eGeouHqKxXV5pUuKE4zz7dFj8WfuZ+81PSLYec5m4=
+github.com/stretchr/testify v1.7.0 h1:nwc3DEeHmmLAfoZucVR881uASk0Mfjw8xYJ99tb5CcY=
+github.com/stretchr/testify v1.7.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
 github.com/urfave/cli/v2 v2.1.1/go.mod h1:SE9GqnLQmjVa0iPEY0f1w3ygNIYcIJ0OKPMoW2caLfQ=
 github.com/vektah/dataloaden v0.2.1-0.20190515034641-a19b9a6e7c9e/go.mod h1:/HUdMve7rvxZma+2ZELQeNh88+003LL7Pf/CZ089j8U=
 github.com/vektah/gqlparser/v2 v2.1.0 h1:uiKJ+T5HMGGQM2kRKQ8Pxw8+Zq9qhhZhz/lieYvCMns=
@@ -96,5 +97,7 @@ gopkg.in/check.v1 v1.0.0-20190902080502-41f04d3bba15/go.mod h1:Co6ibVJAznAaIkqp8
 gopkg.in/yaml.v2 v2.2.2/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
 gopkg.in/yaml.v2 v2.2.4 h1:/eiJrUcujPVeJ3xlSWaiNi3uSVmDGBK1pDHUHAnao1I=
 gopkg.in/yaml.v2 v2.2.4/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
+gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c h1:dUUwHk2QECo/6vqA44rthZ8ie2QXMNeKRTHCNY2nXvo=
+gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
 sourcegraph.com/sourcegraph/appdash v0.0.0-20180110180208-2cc67fd64755/go.mod h1:hI742Nqp5OhwiqlzhgfbWU4mW4yO10fP+LoT9WOswdU=
 sourcegraph.com/sourcegraph/appdash-data v0.0.0-20151005221446-73f23eafcf67/go.mod h1:L5q+DGLGOQFpo1snNEkLOJT2d1YTW66rWNzatr3He1k=

server.go

@@ -24,6 +24,8 @@ var (
 
 var logger global.Logger
 
+//go:generate go run ./generators/default_dir_const_gen.go
+
 func main() {
 	versionFlag := flag.Bool("version", false, "To get the current version of gitconvex")
 	portFlag := flag.String("port", "", "To define the port dynamically while starting gitconvex")

utils/default_dir_setup.go

@@ -1,7 +1,6 @@
 package utils
 
 import (
-	"flag"
 	"github.com/neel1996/gitconvex/global"
 	"go/types"
 	"os"
@@ -10,19 +9,10 @@ import (
 )
 
 func DefaultDirSetup() (string, error) {
-	var baseDirPath *string
-	baseDirFlag := flag.Lookup("basedir")
+	baseDirPath := global.GetDefaultDirectory()
 
-	if baseDirFlag == nil {
-		baseDirPath = flag.String("basedir", "/usr/local/gitconvex", "Default gitconvex directory path for Linux and MacOS")
-		flag.Parse()
-	} else {
-		flagPath := baseDirFlag.Value.String()
-		baseDirPath = &flagPath
-	}
-
-	if baseDirPath == nil {
-		return "", types.Error{Msg: "Unable to parse basedir flag"}
+	if baseDirPath == "" {
+		return "", types.Error{Msg: "Default directory path value is empty"}
 	}
 
 	if runtime.GOOS == "windows" {
@@ -38,15 +28,15 @@ func DefaultDirSetup() (string, error) {
 		return execPath, nil
 	}
 
-	_, statErr := os.Stat(*baseDirPath)
+	_, statErr := os.Stat(baseDirPath)
 	if statErr != nil {
-		err := os.Mkdir(*baseDirPath, 0755)
+		err := os.Mkdir(baseDirPath, 0644)
 		if err != nil {
 			logger.Log(err.Error(), global.StatusError)
 			return "", err
 		}
 	} else {
-		return *baseDirPath, nil
+		return baseDirPath, nil
 	}
 
 	return "", nil