improve test coverage for validators

Author: neel1996

validator/branch_validator_test.go

@@ -30,9 +30,16 @@ func (suite *BranchValidatorTestSuite) TestValidate_WhenPassedBranchesAreValid_S
 	suite.Nil(err)
 }
 
-func (suite *BranchValidatorTestSuite) TestValidate_WhenPassedEmptyStringIsPassed_ShouldReturnEmptybranchError() {
+func (suite *BranchValidatorTestSuite) TestValidate_WhenNoBranchesArePassed_ShouldReturnEmptyBranchError() {
 	err := suite.branchValidator.ValidateWithFields()
 
 	suite.NotNil(err)
 	suite.Equal(EmptyBranchName, err)
 }
+
+func (suite *BranchValidatorTestSuite) TestValidate_WhenEmptyStringIsPassed_ShouldReturnEmptyBranchError() {
+	err := suite.branchValidator.ValidateWithFields("")
+
+	suite.NotNil(err)
+	suite.Equal(EmptyBranchName, err)
+}

validator/repo_validator_test.go

@@ -42,3 +42,12 @@ func (suite *RepoValidatorTestSuite) TestValidate_WhenRepoIsNil_ShouldReturnRepo
 	suite.NotNil(err)
 	suite.Equal(NilRepoError, err)
 }
+
+func (suite *RepoValidatorTestSuite) TestValidate_WhenWrongTypeOfInputIsPassed_ShouldReturnRepoNilError() {
+	suite.repoValidator = NewRepoValidator()
+
+	err := suite.repoValidator.Validate("nil")
+
+	suite.NotNil(err)
+	suite.Equal(NilRepoError, err)
+}

validator/validation_errors_test.go

@@ -0,0 +1,21 @@
+package validator
+
+import (
+	"github.com/stretchr/testify/suite"
+	"testing"
+)
+
+type ValidationErrorTestSuite struct {
+	suite.Suite
+	validationError Error
+}
+
+func TestValidationErrorTestSuite(t *testing.T) {
+	suite.Run(t, new(ValidationErrorTestSuite))
+}
+
+func (suite *ValidationErrorTestSuite) TestError_ShouldReturnErrorString() {
+	suite.validationError = NilRepoError
+
+	suite.Equal("Repo is nil", suite.validationError.Error())
+}