revise tests for get remote name api

Author: neel1996

generate_all_mocks.sh

@@ -6,4 +6,6 @@ mockgen -source=git/middleware/reference.go -destination=mocks/mock_reference.go
 mockgen -source=git/middleware/index.go -destination=mocks/mock_index.go -package=mocks
 mockgen -source=git/commit/git_list_all_commit_logs.go -destination=mocks/mock_git_list_all_commit_logs.go -package=mocks
 mockgen -source=git/middleware/commit.go -destination=mocks/mock_commit.go -package=mocks
-mockgen -source=git/commit/git_commit_file_history.go -destination=mocks/mock_git_commit_file_history.go -package=mocks
+mockgen -source=git/commit/git_commit_file_history.go -destination=mocks/mock_git_commit_file_history.go -package=mocks
+mockgen -source=git/remote/remote_validation.go -destination=mocks/mock_remote_validation.go -package=mocks
+mockgen -source=git/remote/git_remote_list.go -destination=mock_git_remote_list.go -package=mocks

git/remote/git_remote_remote_name.go

@@ -10,19 +10,19 @@ type Name interface {
 }
 
 type remoteName struct {
-	repo      middleware.Repository
-	remoteUrl string
+	repo             middleware.Repository
+	remoteUrl        string
+	remoteValidation Validation
+	remoteList       List
 }
 
 func (r remoteName) GetRemoteNameWithUrl() string {
-	repo := r.repo
-
-	if validationErr := NewRemoteValidation(repo).ValidateRemoteFields(); validationErr != nil {
+	if validationErr := r.remoteValidation.ValidateRemoteFields(); validationErr != nil {
 		logger.Log(validationErr.Error(), global.StatusError)
 		return ""
 	}
 
-	remoteList := NewRemoteList(r.repo).GetAllRemotes()
+	remoteList := r.remoteList.GetAllRemotes()
 	if remoteList == nil {
 		logger.Log("repo has no remotes", global.StatusError)
 		return ""
@@ -38,9 +38,11 @@ func (r remoteName) GetRemoteNameWithUrl() string {
 	return ""
 }
 
-func NewGetRemoteName(repo middleware.Repository, remoteUrl string) Name {
+func NewGetRemoteName(repo middleware.Repository, remoteUrl string, remoteValidation Validation, remoteList List) Name {
 	return remoteName{
-		repo:      repo,
-		remoteUrl: remoteUrl,
+		repo:             repo,
+		remoteUrl:        remoteUrl,
+		remoteValidation: remoteValidation,
+		remoteList:       remoteList,
 	}
 }

git/remote/git_remote_remote_name_test.go

@@ -1,60 +1,87 @@
 package remote
 
 import (
+	"errors"
 	"fmt"
+	"github.com/golang/mock/gomock"
 	git2go "github.com/libgit2/git2go/v31"
+	"github.com/neel1996/gitconvex/git/middleware"
+	"github.com/neel1996/gitconvex/mocks"
 	"github.com/stretchr/testify/suite"
 	"os"
-	"path/filepath"
 	"testing"
 )
 
 type GetRemoteNameTestSuite struct {
 	suite.Suite
-	getRemoteName Name
-	repo          *git2go.Repository
-	noHeadRepo    *git2go.Repository
+	getRemoteName        Name
+	repo                 middleware.Repository
+	remoteValidation     Validation
+	remoteList           List
+	mockController       *gomock.Controller
+	mockRepo             *mocks.MockRepository
+	mockRemoteValidation *mocks.MockValidation
+	mockRemoteList       *mocks.MockList
+	noHeadRepo           *git2go.Repository
 }
 
 func (suite *GetRemoteNameTestSuite) SetupTest() {
 	r, err := git2go.OpenRepository(os.Getenv("GITCONVEX_TEST_REPO"))
 	if err != nil {
 		fmt.Println(err)
 	}
-	noHeadPath := os.Getenv("GITCONVEX_TEST_REPO") + string(filepath.Separator) + "no_head"
-	noHeadRepo, _ := git2go.OpenRepository(noHeadPath)
 
-	suite.repo = r
-	suite.noHeadRepo = noHeadRepo
-	suite.getRemoteName = NewGetRemoteName(suite.repo, "https://github.com/neel1996/gitconvex-test.git")
+	suite.repo = middleware.NewRepository(r)
+	suite.remoteValidation = NewRemoteValidation(suite.repo)
+	suite.remoteList = NewRemoteList(suite.repo)
+	suite.mockController = gomock.NewController(suite.T())
+	suite.mockRepo = mocks.NewMockRepository(suite.mockController)
+	suite.mockRemoteValidation = mocks.NewMockValidation(suite.mockController)
+	suite.mockRemoteList = mocks.NewMockList(suite.mockController)
+	suite.getRemoteName = NewGetRemoteName(
+		suite.mockRepo,
+		"https://github.com/neel1996/gitconvex-test.git",
+		suite.mockRemoteValidation,
+		suite.mockRemoteList,
+	)
 }
 
 func TestGetRemoteNameTestSuite(t *testing.T) {
 	suite.Run(t, new(GetRemoteNameTestSuite))
 }
 
 func (suite *GetRemoteNameTestSuite) TestGetRemoteName_ShouldReturnRemoteName_WhenRemoteUrlIsValid() {
+	suite.getRemoteName = NewGetRemoteName(
+		suite.repo,
+		"https://github.com/neel1996/gitconvex-test.git",
+		suite.remoteValidation,
+		suite.remoteList,
+	)
+
 	expectedRemote := "origin"
 
 	actualRemote := suite.getRemoteName.GetRemoteNameWithUrl()
 
 	suite.Equal(expectedRemote, actualRemote)
 }
 
-func (suite *GetRemoteNameTestSuite) TestGetRemoteName_ShouldReturnEmptyString_WhenRepoIsNil() {
+func (suite *GetRemoteNameTestSuite) TestGetRemoteName_ShouldReturnEmptyString_WhenValidationFails() {
 	expectedRemote := ""
-	getRemoteName := NewGetRemoteName(nil, "https://github.com/neel1996/gitconvex-test.git")
 
-	actualRemote := getRemoteName.GetRemoteNameWithUrl()
+	suite.mockRemoteValidation.EXPECT().ValidateRemoteFields().Return(errors.New("VALIDATION_ERROR"))
+
+	actualRemote := suite.getRemoteName.GetRemoteNameWithUrl()
 
 	suite.Equal(expectedRemote, actualRemote)
 }
 
 func (suite *GetRemoteNameTestSuite) TestGetRemoteName_ShouldReturnEmptyString_WhenRepoHasNoRemotes() {
 	expectedRemote := ""
-	getRemoteName := NewGetRemoteName(suite.noHeadRepo, "https://github.com/neel1996/gitconvex-test.git")
 
-	actualRemote := getRemoteName.GetRemoteNameWithUrl()
+	suite.mockRemoteValidation.EXPECT().ValidateRemoteFields().Return(nil)
+	suite.mockRemoteList.EXPECT().GetAllRemotes().Return(nil)
+
+	actualRemote := suite.getRemoteName.GetRemoteNameWithUrl()
 
 	suite.Equal(expectedRemote, actualRemote)
 }