restore global package and create new package for errors

Author: neel1996

constants/common_strings.go

@@ -0,0 +1,32 @@
+package constants
+
+type ApiError struct {
+	error
+	ErrorCode   string
+	ErrorString string
+}
+
+var (
+	BranchAddError       = ApiError{ErrorCode: "BRANCH_ADD_FAILED", ErrorString: "Failed to add new branch"}
+	BranchCheckoutError  = ApiError{ErrorCode: "CHECKOUT_FAILED", ErrorString: "Failed to checkout branch"}
+	BranchDeleteError    = ApiError{ErrorCode: "BRANCH_DELETE_FAILED", ErrorString: "Failed to delete branch"}
+	RemoteAddError       = ApiError{ErrorCode: "REMOTE_ADD_FAILED", ErrorString: "Failed to delete add new remote"}
+	RemoteDeleteError    = ApiError{ErrorCode: "REMOTE_DELETE_FAILED", ErrorString: "Failed to delete add new remote"}
+	RemoteEditError      = ApiError{ErrorCode: "REMOTE_EDIT_FAILED", ErrorString: "Failed to delete add new remote"}
+	FetchFromRemoteError = ApiError{ErrorCode: "FETCH_ERROR", ErrorString: "Failed to delete add new remote"}
+	PullFromRemoteError  = ApiError{ErrorCode: "PULL_ERROR", ErrorString: "Failed to delete add new remote"}
+	StageItemError       = ApiError{ErrorCode: "ADD_ITEM_FAILED", ErrorString: "Failed to delete add new remote"}
+	StageAllItemsError   = ApiError{ErrorCode: "ALL_STAGE_FAILED", ErrorString: "Failed to delete add new remote"}
+	RemoveItemError      = ApiError{ErrorCode: "STAGE_REMOVE_FAILED", ErrorString: "Failed to delete add new remote"}
+	RemoveAllItemsError  = ApiError{ErrorCode: "STAGE_ALL_REMOVE_FAILED", ErrorString: "Failed to delete add new remote"}
+	CommitChangeError    = ApiError{ErrorCode: "COMMIT_FAILED", ErrorString: "Failed to delete add new remote"}
+	PushToRemoteError    = ApiError{ErrorCode: "PUSH_FAILED", ErrorString: "Failed to delete add new remote"}
+	PortUpdateError      = ApiError{ErrorCode: "PORT_UPDATE_FAILED", ErrorString: "Failed to delete add new remote"}
+	DataFileUpdateError  = ApiError{ErrorCode: "DATAFILE_UPDATE_FAILED", ErrorString: "Failed to delete add new remote"}
+	RepoDeleteError      = ApiError{ErrorCode: "DELETE_FAILED", ErrorString: "Failed to delete add new remote"}
+	CommitLogsError      = ApiError{ErrorCode: "LIST_COMMIT_LOGS_FAILED", ErrorString: "Failed to delete add new remote"}
+)
+
+func (e ApiError) Error() string {
+	return e.ErrorString
+}

constants/current_version.go

@@ -25,15 +25,10 @@ func (t totalCommits) Get() int {
 	var total = 0
 	repo := t.repo
 
-	logItr, itrErr := repo.Walk()
-	if itrErr != nil {
-		logger.Log(fmt.Sprintf("Repo has no logs -> %s", itrErr.Error()), global.StatusError)
-		return total
-	}
-
-	commits, err := t.allCommitLogs(logItr)
+	allLogs := NewListAllLogs(repo)
+	commits, err := allLogs.Get()
 	if err != nil {
-		logger.Log(fmt.Sprintf("Unable to obtain commits for the repo"), global.StatusError)
+		logger.Log(fmt.Sprintf("Unable to obtain commits for the repo : %v", err.Error()), global.StatusError)
 		return total
 	}
 
@@ -47,26 +42,6 @@ func (t totalCommits) Get() int {
 	return total
 }
 
-func (t totalCommits) allCommitLogs(logItr middleware.RevWalk) ([]git2go.Commit, error) {
-	var c commitType
-	_ = logItr.PushHead()
-
-	err := logItr.Iterate(revIterator(&c))
-
-	return c.commits, err
-}
-
-func revIterator(c *commitType) git2go.RevWalkIterator {
-	return func(commit *git2go.Commit) bool {
-		if commit != nil {
-			c.commits = append(c.commits, *commit)
-			return true
-		}
-
-		return false
-	}
-}
-
 func NewTotalCommits(repo middleware.Repository) Total {
 	return totalCommits{repo: repo}
 }

constants/default_dir_const.go

@@ -5,8 +5,6 @@ const (
 	BranchCheckoutError  = "CHECKOUT_FAILED"
 	BranchDeleteError    = "BRANCH_DELETE_FAILED"
 	RemoteAddError       = "REMOTE_ADD_FAILED"
-	RemoteDeleteError    = "REMOTE_DELETE_FAILED"
-	RemoteEditError      = "REMOTE_EDIT_FAILED"
 	FetchFromRemoteError = "FETCH_ERROR"
 	PullFromRemoteError  = "PULL_ERROR"
 	StageItemError       = "ADD_ITEM_FAILED"