Skip to content

Commit def51f1

Browse files
IoannisPanagiotasvnickolov
authored andcommitted
log progress also for filtered out walks
1 parent 00a152a commit def51f1

File tree

1 file changed

+12
-7
lines changed

1 file changed

+12
-7
lines changed

algo/src/main/java/org/neo4j/gds/embeddings/node2vec/PositiveSampleProducer.java

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -75,26 +75,31 @@ public boolean next(long[] buffer) {
7575
return false;
7676
}
7777

78+
private boolean skipWalk(long[] walk){
79+
int filteredWalkLength = filter(walk);
80+
boolean skipWalk = filteredWalkLength < 2;
81+
if (skipWalk){
82+
progressTracker.logProgress(); //a walk has been sampled and ignored
83+
}
84+
return skipWalk;
85+
}
7886
private boolean nextWalk() {
7987
if (attemptedSamplingWalks){ //this means a walk has been exhausted
8088
progressTracker.logProgress();
8189
}
82-
attemptedSamplingWalks = true; //this is because first time nextWalk() is called, it doesnt have any walk lol
90+
attemptedSamplingWalks = true; //this is because first time nextWalk() is called, it doesnt have any walk
8391

8492
if (!walks.hasNext()) {
8593
return false;
8694
}
8795
long[] walk = walks.next();
8896

89-
int filteredWalkLength = filter(walk);
90-
91-
while (filteredWalkLength < 2 && walks.hasNext()) {
97+
boolean walkSkipped;
98+
while ((walkSkipped = skipWalk(walk)) && walks.hasNext()) {
9299
walk = walks.next();
93-
filteredWalkLength = filter(walk);
94-
95100
}
96101

97-
if (filteredWalkLength >= 2) {
102+
if (!walkSkipped) {
98103
this.currentWalk = walk;
99104
centerWordIndex = -1;
100105
return nextCenterWord();

0 commit comments

Comments
 (0)