Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenGDS JAR as release asset #275

Open
JohT opened this issue Jul 11, 2023 · 5 comments
Open

OpenGDS JAR as release asset #275

JohT opened this issue Jul 11, 2023 · 5 comments
Labels
feature request A suggestion for a new feature

Comments

@JohT
Copy link

JohT commented Jul 11, 2023

It would be great to get the OpenGDS JAR as release asset additionally to the existing one.

The steps to do that are already described in the main documentation under Building the library/Packaging the library. This could be done with GitHub Actions in an automated manner. Of course, this would need to fit/join the current release process (that I'm not aware of).

Alternatives

An alternative would be to create an own non official repository that clones this repository, creates the bundle and then releases it.

Additional context

I'm open to contribute GitHub Action(s) if this is of any help.

PS.: Thanks 👏 for this awesome library.

@JohT JohT added the feature request A suggestion for a new feature label Jul 11, 2023
@FlorentinD
Copy link
Contributor

Hello @JohT ,
thanks for your request.
Could you explain why you want to use the OpenGDS jar?

@JohT
Copy link
Author

JohT commented Jul 17, 2023

Hi @FlorentinD,

thanks for your response. The main README.md states in section opengds that:

The Neo4j Graph Data Science library as built and distributed by Neo4j includes the sources in this repository as well a suite of closed sources. Neo4j GDS is available to download and use under the constraints of its license.

This makes me unsure if it is a good idea to just use the release artifacts provided. I'm not a lawyer so i assume, that the open version is a better fit for open projects like mine: https://github.com/JohT/code-graph-analysis-pipeline

@Mats-SX Mats-SX closed this as not planned Won't fix, can't repro, duplicate, stale Jul 31, 2023
@Mats-SX
Copy link
Contributor

Mats-SX commented Jul 31, 2023

Disregard my previous reply, it contained inaccuracies (so I deleted it).

@Mats-SX Mats-SX reopened this Jul 31, 2023
@JohT
Copy link
Author

JohT commented Jul 31, 2023

No worries. I found it insightful and am now curious about the inaccuracies.😀

I forgot to mention that I've created the following repository that automates the Open Graph Data Science build, packaging and release: https://github.com/JohT/open-graph-data-science-packaging

It is only a temporary solution and I might be removed in future.

@Mats-SX
Copy link
Contributor

Mats-SX commented Jul 31, 2023

Well, I was mistaken on the license we ship with Neo4j GDS. It does indeed not fit for your purpose, so your request (and solution) is valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A suggestion for a new feature
Projects
None yet
Development

No branches or pull requests

3 participants