Close #175

Author: neomerx

src/Contracts/Schema/ResourceObjectInterface.php

@@ -33,7 +33,7 @@ public function getType();
     /**
      * Get resource ID.
      *
-     * @return string
+     * @return string|null
      */
     public function getId();
 

src/Document/Presenters/ElementPresenter.php

@@ -288,8 +288,10 @@ private function convertResourceToArray(ResourceObjectInterface $resource, $reso
     {
         $representation = [
             Document::KEYWORD_TYPE => $resource->getType(),
-            Document::KEYWORD_ID   => $resource->getId(),
         ];
+        if (($resourceId = $resource->getId()) !== null) {
+            $representation[Document::KEYWORD_ID] = $resourceId;
+        }
 
         $attributes = $resource->getAttributes();
 

src/Schema/ResourceObject.php

@@ -27,9 +27,9 @@
 class ResourceObject implements ResourceObjectInterface
 {
     /**
-     * @var string
+     * @var string|false
      */
-    private $idx;
+    private $idx = false;
 
     /**
      * @var array
@@ -149,7 +149,12 @@ public function getType()
      */
     public function getId()
     {
-        return $this->idx === null ? $this->idx = (string)$this->schema->getId($this->resource) : $this->idx;
+        if ($this->idx === false) {
+            $index = $this->schema->getId($this->resource);
+            $this->idx = $index === null ? $index : (string)$index;
+        }
+
+        return $this->idx;
     }
 
     /**

tests/Data/AuthorSchema.php

@@ -52,7 +52,7 @@ public function getAttributes($author)
      */
     public function getRelationships($author, $isPrimary, array $includeRelationships)
     {
-        assert('$author instanceof '.Author::class);
+        assert('$author instanceof '. Author::class);
 
         if (($isPrimary && $this->isIsLinksInPrimary()) || (!$isPrimary && $this->isIsLinksInIncluded())) {
             $selfLink = $this->getRelationshipSelfLink($author, Author::LINK_COMMENTS);

tests/Encoder/EncodeSimpleObjectsTest.php

@@ -175,6 +175,43 @@ public function testEncodeObjectWithAttributesOnly()
         $this->assertEquals($expected, $actual);
     }
 
+    /**
+     * Test encode simple object without ID and attributes only.
+     */
+    public function testEncodeObjectWithAttributesOnlyAndNoId()
+    {
+        $author  = Author::instance(9, 'Dan', 'Gebhardt');
+        $author->{Author::ATTRIBUTE_ID} = null;
+        $encoder = Encoder::instance([
+            Author::class => function ($factory) {
+                $schema = new AuthorSchema($factory);
+                $schema->linkRemove(Author::LINK_COMMENTS);
+                $schema->setResourceLinksClosure(function () {
+                    return []; // no `self` link and others
+                });
+                return $schema;
+            }
+        ], $this->encoderOptions);
+
+        $actual = $encoder->encodeData($author);
+
+        $expected = <<<EOL
+        {
+            "data" : {
+                "type"       : "people",
+                "attributes" : {
+                    "first_name" : "Dan",
+                    "last_name"  : "Gebhardt"
+                }
+            }
+        }
+EOL;
+        // remove formatting from 'expected'
+        $expected = json_encode(json_decode($expected));
+
+        $this->assertEquals($expected, $actual);
+    }
+
     /**
      * Test encode simple object with attributes and custom links.
      *