Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Email in notifications #13

Open
etfb opened this issue Jan 28, 2025 · 2 comments
Open

HTML Email in notifications #13

etfb opened this issue Jan 28, 2025 · 2 comments

Comments

@etfb
Copy link

etfb commented Jan 28, 2025

Hi - I've cloned the repo and made a local branch with a couple of simple changes that fix the email notifications. Previously, when User A sends a private message to User B, if User B has notifications enabled for email they receive an email that looks like this:

You have received a new message from User A!
<br />
Text of the message.
<br />
<a href="https://.../conversations/3" target="_blank" style="padding: 0.5em 1em; background: #ADD445; color: #000000;">View message</a>
<br />
<a href="https://.../settings">Manage email settings</a>

I've changed it so now it looks like this:

Image

I can't make a PR because I don't have access, but if you want to add me (etfb, [email protected]) then I will make the PR immediately.

Thanks!

@neoncube2
Copy link
Owner

neoncube2 commented Feb 5, 2025

This sounds great, thank you! :D

In order to create a PR, you need to:

  1. Go to https://github.com/neoncube2/flarum-private-messages and click the "Fork" button
  2. Clone the new forked repo to your computer
  3. Copy and paste the contents of your local branch into the forked repo
  4. Commit and push the changes on the forked repo
  5. Go to your forked repo on Github and open a PR

If that's too complicated, you could email a zipped copy of the new code to [email protected] or post the code changes to this thread, though :)

Thanks again! :)

@etfb
Copy link
Author

etfb commented Feb 5, 2025

Not that complicated -- your instructions were perfectly clear, thanks! I've done that, even though it might have been even easier just to post the two changes, so I could be sure I've got the steps right for the next time I want to make a contribution. Can you see the PR, or do I need to send you a link?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants