remove serializer

Author: arthanson

netbox_custom_objects/models.py

@@ -619,10 +619,12 @@ def wrapped_post_through_setup(self, cls):
         # is no recursion.
         apps.clear_cache()
 
+        '''
         # Register the serializer for this model
         from netbox_custom_objects.api.serializers import get_serializer_class
 
         get_serializer_class(model)
+        '''
 
         # Register the global SearchIndex for this model
         self.register_custom_object_search_index(model)

netbox_custom_objects/views.py

@@ -28,6 +28,7 @@
 from . import field_types, filtersets, forms, tables
 from .models import CustomObject, CustomObjectType, CustomObjectTypeField
 from extras.choices import CustomFieldTypeChoices
+from netbox_custom_objects.api.serializers import get_serializer_class
 from netbox_custom_objects.constants import APP_LABEL
 
 logger = logging.getLogger("netbox_custom_objects.views")
@@ -141,6 +142,14 @@ def get_table(self, data, request, bulk_actions=True):
         return super().get_table(data, request, bulk_actions=bulk_actions)
 
 
+class CustomObjectModelMixin:
+    def get_model(self, custom_object_type):
+        model = custom_object_type.get_model()
+        get_serializer_class(model)
+        custom_object_type.register_custom_object_search_index(model)
+        return model
+
+
 #
 # Custom Object Types
 #
@@ -155,17 +164,17 @@ class CustomObjectTypeListView(generic.ObjectListView):
 
 
 @register_model_view(CustomObjectType)
-class CustomObjectTypeView(CustomObjectTableMixin, generic.ObjectView):
+class CustomObjectTypeView(CustomObjectTableMixin, CustomObjectModelMixin, generic.ObjectView):
     queryset = CustomObjectType.objects.all()
 
     def get_table(self, data, request, bulk_actions=True):
         self.custom_object_type = self.get_object(**self.kwargs)
-        model = self.custom_object_type.get_model()
+        model = self.get_model(self.custom_object_type)
         data = model.objects.all()
         return super().get_table(data, request, bulk_actions=False)
 
     def get_extra_context(self, request, instance):
-        model = instance.get_model()
+        model = self.get_model(instance)
 
         # Get fields and group them by group_name
         fields = instance.fields.all().order_by("group_name", "weight", "name")
@@ -193,13 +202,13 @@ class CustomObjectTypeEditView(generic.ObjectEditView):
 
 
 @register_model_view(CustomObjectType, "delete")
-class CustomObjectTypeDeleteView(generic.ObjectDeleteView):
+class CustomObjectTypeDeleteView(CustomObjectModelMixin, generic.ObjectDeleteView):
     queryset = CustomObjectType.objects.all()
     default_return_url = "plugins:netbox_custom_objects:customobjecttype_list"
 
     def _get_dependent_objects(self, obj):
         dependent_objects = super()._get_dependent_objects(obj)
-        model = obj.get_model()
+        model = self.get_model(obj)
         dependent_objects[model] = list(model.objects.all())
 
         # Find CustomObjectTypeFields that reference this CustomObjectType
@@ -226,7 +235,7 @@ class CustomObjectTypeFieldEditView(generic.ObjectEditView):
 
 
 @register_model_view(CustomObjectTypeField, "delete")
-class CustomObjectTypeFieldDeleteView(generic.ObjectDeleteView):
+class CustomObjectTypeFieldDeleteView(CustomObjectModelMixin, generic.ObjectDeleteView):
     template_name = "netbox_custom_objects/field_delete.html"
     queryset = CustomObjectTypeField.objects.all()
 
@@ -243,7 +252,7 @@ def get(self, request, *args, **kwargs):
         obj = self.get_object(**kwargs)
         form = ConfirmationForm(initial=request.GET)
 
-        model = obj.custom_object_type.get_model()
+        model = self.get_model(obj.custom_object_type)
         kwargs = {
             f"{obj.name}__isnull": False,
         }
@@ -280,7 +289,7 @@ def get(self, request, *args, **kwargs):
 
     def _get_dependent_objects(self, obj):
         dependent_objects = super()._get_dependent_objects(obj)
-        model = obj.custom_object_type.get_model()
+        model = self.get_model(obj.custom_object_type)
         kwargs = {
             f"{obj.name}__isnull": False,
         }
@@ -314,7 +323,7 @@ class CustomObjectTypeBulkDeleteView(generic.BulkDeleteView):
 #
 
 
-class CustomObjectListView(CustomObjectTableMixin, generic.ObjectListView):
+class CustomObjectListView(CustomObjectTableMixin, CustomObjectModelMixin, generic.ObjectListView):
     queryset = None
     custom_object_type = None
     template_name = "netbox_custom_objects/custom_object_list.html"
@@ -332,7 +341,7 @@ def get_queryset(self, request):
         self.custom_object_type = get_object_or_404(
             CustomObjectType, slug=custom_object_type
         )
-        model = self.custom_object_type.get_model()
+        model = self.get_model(self.custom_object_type)
         return model.objects.all()
 
     def get_filterset(self):
@@ -370,23 +379,23 @@ def get_extra_context(self, request):
 
 
 @register_model_view(CustomObject)
-class CustomObjectView(generic.ObjectView):
+class CustomObjectView(CustomObjectModelMixin, generic.ObjectView):
     template_name = "netbox_custom_objects/customobject.html"
 
     def get_queryset(self, request):
         custom_object_type = self.kwargs.get("custom_object_type", None)
         object_type = get_object_or_404(
             CustomObjectType, slug=custom_object_type
         )
-        model = object_type.get_model()
+        model = self.get_model(object_type)
         return model.objects.all()
 
     def get_object(self, **kwargs):
         custom_object_type = self.kwargs.get("custom_object_type", None)
         object_type = get_object_or_404(
             CustomObjectType, slug=custom_object_type
         )
-        model = object_type.get_model()
+        model = self.get_model(object_type)
         # Filter out custom_object_type from kwargs for the object lookup
         lookup_kwargs = {
             k: v for k, v in self.kwargs.items() if k != "custom_object_type"
@@ -413,7 +422,7 @@ def get_extra_context(self, request, instance):
 
 
 @register_model_view(CustomObject, "edit")
-class CustomObjectEditView(generic.ObjectEditView):
+class CustomObjectEditView(CustomObjectModelMixin, generic.ObjectEditView):
     template_name = "netbox_custom_objects/customobject_edit.html"
     form = None
     queryset = None
@@ -436,7 +445,8 @@ def get_object(self, **kwargs):
         object_type = get_object_or_404(
             CustomObjectType, slug=custom_object_type
         )
-        model = object_type.get_model()
+        model = self.get_model(object_type)
+
         if not self.kwargs.get("pk", None):
             # We're creating a new object
             return model()
@@ -573,7 +583,7 @@ def custom_save(self, commit=True):
 
 
 @register_model_view(CustomObject, "delete")
-class CustomObjectDeleteView(generic.ObjectDeleteView):
+class CustomObjectDeleteView(CustomObjectModelMixin, generic.ObjectDeleteView):
     queryset = None
     object = None
     default_return_url = "plugins:netbox_custom_objects:customobject_list"
@@ -593,7 +603,7 @@ def get_object(self, **kwargs):
         object_type = get_object_or_404(
             CustomObjectType, slug=custom_object_type
         )
-        model = object_type.get_model()
+        model = self.get_model(object_type)
         return get_object_or_404(model.objects.all(), **self.kwargs)
 
     def get_return_url(self, request, obj=None):
@@ -614,7 +624,7 @@ def get_return_url(self, request, obj=None):
 
 
 @register_model_view(CustomObject, "bulk_edit", path="edit", detail=False)
-class CustomObjectBulkEditView(CustomObjectTableMixin, generic.BulkEditView):
+class CustomObjectBulkEditView(CustomObjectTableMixin, CustomObjectModelMixin, generic.BulkEditView):
     queryset = None
     custom_object_type = None
     table = None
@@ -633,7 +643,7 @@ def get_queryset(self, request):
         self.custom_object_type = CustomObjectType.objects.get(
             slug=custom_object_type
         )
-        model = self.custom_object_type.get_model()
+        model = self.get_model(self.custom_object_type)
         return model.objects.all()
 
     def get_form(self, queryset):
@@ -673,7 +683,7 @@ def get_form(self, queryset):
 
 
 @register_model_view(CustomObject, "bulk_delete", path="delete", detail=False)
-class CustomObjectBulkDeleteView(CustomObjectTableMixin, generic.BulkDeleteView):
+class CustomObjectBulkDeleteView(CustomObjectTableMixin, CustomObjectModelMixin, generic.BulkDeleteView):
     queryset = None
     custom_object_type = None
     table = None
@@ -691,12 +701,12 @@ def get_queryset(self, request):
         self.custom_object_type = CustomObjectType.objects.get(
             slug=custom_object_type
         )
-        model = self.custom_object_type.get_model()
+        model = self.get_model(self.custom_object_type)
         return model.objects.all()
 
 
 @register_model_view(CustomObject, "bulk_import", path="import", detail=False)
-class CustomObjectBulkImportView(generic.BulkImportView):
+class CustomObjectBulkImportView(CustomObjectModelMixin, generic.BulkImportView):
     queryset = None
     model_form = None
 
@@ -720,7 +730,7 @@ def get_queryset(self, request):
         self.custom_object_type = CustomObjectType.objects.get(
             name__iexact=custom_object_type
         )
-        model = self.custom_object_type.get_model()
+        model = self.get_model(self.custom_object_type)
         return model.objects.all()
 
     def get_model_form(self, queryset):
@@ -756,7 +766,7 @@ def get_model_form(self, queryset):
         return form
 
 
-class CustomObjectJournalView(ConditionalLoginRequiredMixin, View):
+class CustomObjectJournalView(ConditionalLoginRequiredMixin, CustomObjectModelMixin, View):
     """
     Custom journal view for CustomObject instances.
     Shows all journal entries for a custom object.
@@ -772,7 +782,7 @@ def get(self, request, custom_object_type, **kwargs):
         object_type = get_object_or_404(
             CustomObjectType, slug=custom_object_type
         )
-        model = object_type.get_model()
+        model = self.get_model(object_type)
 
         # Get the specific object
         lookup_kwargs = {k: v for k, v in kwargs.items() if k != "custom_object_type"}
@@ -828,7 +838,7 @@ def get(self, request, custom_object_type, **kwargs):
         )
 
 
-class CustomObjectChangeLogView(ConditionalLoginRequiredMixin, View):
+class CustomObjectChangeLogView(ConditionalLoginRequiredMixin, CustomObjectModelMixin, View):
     """
     Custom changelog view for CustomObject instances.
     Shows all changes made to a custom object.
@@ -844,7 +854,7 @@ def get(self, request, custom_object_type, **kwargs):
         object_type = get_object_or_404(
             CustomObjectType, slug=custom_object_type
         )
-        model = object_type.get_model()
+        model = self.get_model(object_type)
 
         # Get the specific object
         lookup_kwargs = {k: v for k, v in kwargs.items() if k != "custom_object_type"}