Backport Rust 2024 vendor compatibility fixes

Author: ktsaou

.agents/sow/done/SOW-0033-20260728-backport-netdata-rust-2024-drift.md

@@ -0,0 +1,253 @@
+# SOW-0034 - Rust 2024 Migration
+
+## Status
+
+Status: open
+
+Sub-state: Queued behind SOW-0033; preliminary validation evidence identifies the migration surfaces that require full analysis.
+
+## Requirements
+
+### Purpose
+
+Migrate the standalone plugin-ipc Rust crate and every Rust target declared by its manifest to Rust edition 2024 without changing protocol behavior or introducing destructor-order regressions.
+
+### User Request
+
+After completing the surgical Netdata vendor-drift backport first, the user requested a full Rust 2024 migration because Rust 2024 is the durable direction for the project.
+
+### Assistant Understanding
+
+Facts:
+
+- `src/crates/netipc/Cargo.toml` currently selects edition 2021.
+- The manifest declares the NetIPC library plus interop and benchmark binaries located under `tests/fixtures/rust/` and `bench/drivers/rust/`.
+- Netdata's Rust workspace already uses edition 2024 and Rust 1.91.
+- A Rust 2024 compatibility lint check found reserved `gen` identifiers in benchmark drivers.
+- The same check found edition-dependent temporary drop-order changes in SHM and UDS connection loops in benchmark and fixture binaries.
+- Windows-only library compatibility changes are handled by SOW-0033, but full Windows target validation is still required for an edition migration.
+
+Inferences:
+
+- This work is broader than a manifest edit because edition 2024 changes keyword parsing, unsafe syntax requirements, and temporary drop scope.
+- Mechanical suppression of the drop-order lint would be unsafe without proving that session and SHM destructors still run in the intended order.
+
+Unknowns:
+
+- The desired standalone plugin-ipc MSRV after migration; Rust edition 2024 itself does not require adopting Netdata's exact workspace MSRV policy.
+- Whether each reported drop-order site is behaviorally neutral or requires an explicit binding/scope change.
+- Whether additional Windows-only edition findings appear under the native Windows CI/toolchain.
+- Whether README, contributor guidance, CI toolchain declarations, or integration guidance state an edition/MSRV contract that must change.
+
+### Acceptance Criteria
+
+- The standalone Rust manifest selects edition 2024 with an explicitly decided and documented MSRV policy.
+- Every library, test, fixture, interop, and benchmark target declared by the manifest builds under edition 2024.
+- All Rust 2024 compatibility findings are implemented or explicitly rejected with evidence; none are silenced without a behavioral explanation.
+- POSIX Rust tests, coverage requirements, interop, and benchmarks remain valid.
+- Native Windows or project-standard Windows validation covers Named Pipe, Windows SHM, typed service, cache, and declared Windows binaries.
+- C/Rust/Go protocol and interoperability contracts remain unchanged and validated.
+- A same-pattern search and artifact maintenance review cover all Rust targets and public guidance.
+
+## Analysis
+
+Sources checked:
+
+- `src/crates/netipc/Cargo.toml`
+- `src/crates/netipc/src/`
+- `bench/drivers/rust/src/main.rs`
+- `bench/drivers/rust/src/bench_windows.rs`
+- `tests/fixtures/rust/src/bin/interop_shm.rs`
+- SOW-0033 validation output
+- Netdata's edition-2024 NetIPC migration commit `3f646983eac1f001ab652b34383a20aaff35f3eb`
+
+Current state:
+
+- The library and its 380 native tests pass on edition 2021 after the SOW-0033 compatibility backport.
+- Rust 2024 compatibility lints for the vendored library and its unit tests pass under SOW-0033.
+- Full `--all-targets` compatibility lints fail only on broader standalone benchmark/fixture migration surfaces discovered so far.
+
+Risks:
+
+- Rust 2024 temporary lifetime changes can alter the order in which failed connection attempts, live sessions, or SHM mappings are dropped.
+- Expanding MSRV without an explicit decision can break supported downstream builders.
+- POSIX-only validation can miss Windows-gated FFI and transport failures.
+- Updating Rust behavior without checking C and Go interoperability can create cross-language release regressions.
+
+## Pre-Implementation Gate
+
+Status: blocked
+
+Problem / root-cause model:
+
+- The standalone crate is edition 2021 while its downstream Netdata workspace is edition 2024. Source-owned library compatibility drift is addressed separately in SOW-0033, but the standalone manifest also compiles benchmark and fixture binaries that contain edition-2024 keyword and temporary-drop-order findings. A safe migration must analyze those runtime lifetimes rather than treating the work as a mechanical manifest change.
+
+Evidence reviewed:
+
+- `src/crates/netipc/Cargo.toml:4` selects edition 2021 and later manifest entries declare interop and benchmark binaries outside the crate directory.
+- `bench/drivers/rust/src/main.rs:260,266` and `bench/drivers/rust/src/bench_windows.rs:521,527` use `gen`, which is reserved in edition 2024.
+- Rust 2024 compatibility lints report temporary drop-order changes at:
+  - `tests/fixtures/rust/src/bin/interop_shm.rs:81`
+  - `bench/drivers/rust/src/main.rs:400,441,680,818,968,1007`
+- The affected temporaries own `UdsSession` or `ShmContext` values whose `Drop` implementations release transport resources.
+- `netdata/netdata @ 01d56fddc20ac4a73ea74da19e49420cab764ad0`, `src/crates/Cargo.toml:66-67`, uses edition 2024 and Rust 1.91.
+
+Affected contracts and surfaces:
+
+- Rust language edition and MSRV policy.
+- Rust library, unit tests, interop fixtures, and benchmark binaries.
+- POSIX UDS and SHM resource lifetime behavior.
+- Windows Named Pipe and SHM compilation/runtime behavior.
+- CI toolchain declarations, coverage, interop, and benchmark validation.
+- Potential developer and integrator documentation.
+
+Existing patterns to reuse:
+
+- Low-priority Rust validation and coverage scripts under `tests/`.
+- Native Windows validation scripts matching the touched transport/API.
+- Cross-language interop scripts and benchmark generators.
+- Explicit resource-lifetime handling already used in UDS and SHM implementations.
+
+Risk and blast radius:
+
+- Medium: edition migration spans all standalone Rust targets and can change temporary destruction timing.
+- No production service, database, configuration, environment, package installation, network, or runtime process changes are expected.
+- Keep SOW-0033's exact vendor backport isolated in its own completed commit before this migration begins.
+
+Sensitive data handling plan:
+
+- The work requires source, compiler diagnostics, test output, and public repository history only.
+- Durable artifacts will contain no credentials, secrets, customer identifiers, personal data, private endpoints, or production incident details.
+
+Implementation plan:
+
+1. After SOW-0033 closes, inventory every manifest-declared Rust target, Rust toolchain declaration, and edition/MSRV statement.
+2. Analyze every Rust 2024 compatibility diagnostic, with special attention to destructor and resource-release ordering.
+3. Present any irreducible MSRV or lifetime design decisions to the user before implementation.
+4. Apply the decided edition, source, test, CI, and documentation changes.
+5. Validate POSIX, Windows, cross-language interop, coverage, and relevant benchmarks.
+
+Validation plan:
+
+- Run Rust 2024 compatibility lints across all targets before and after implementation.
+- Run formatting, all Rust tests, Rust coverage, POSIX interop, and relevant benchmarks at low scheduler priority.
+- Run the project-standard native Windows validation for Named Pipe, SHM, service, cache, and Rust binaries.
+- Run same-pattern searches for reserved identifiers, unsafe edition findings, and temporary lifetime patterns.
+- Review generated diffs, protocol parity, sensitive data, artifact maintenance, and SOW audit evidence.
+
+Artifact impact plan:
+
+- AGENTS.md: inspect toolchain/validation policy; update only if project-wide requirements change.
+- Runtime project skills: inspect vendoring guidance if edition/MSRV changes affect downstream copying or validation.
+- Specs: update only if supported toolchain or observable resource-lifetime guarantees are specified there.
+- End-user/operator docs: inspect README, getting-started, and integrator guidance for Rust edition/MSRV/build commands.
+- End-user/operator skills: update `docs/netipc-integrator-skill.md` if integration prerequisites or validation commands change.
+- SOW lifecycle: begin only after SOW-0033 is completed; close with every diagnostic implemented, rejected with evidence, or mapped to a real follow-up.
+
+Open-source reference evidence:
+
+- `netdata/netdata @ 01d56fddc20ac4a73ea74da19e49420cab764ad0`
+  - `src/crates/Cargo.toml:66-67`
+  - `src/crates/netipc/Cargo.toml:4`
+  - `src/crates/netipc/src/transport/shm.rs`
+  - `src/crates/netipc/src/transport/win_shm.rs`
+
+Open decisions:
+
+- Blocked until SOW-0033 completes because the project permits only one executing SOW at a time.
+- MSRV selection and any non-mechanical resource-lifetime changes require evidence and user decisions after the full pre-implementation inventory.
+
+## Implications And Decisions
+
+1. **Ordering - selected by the user: surgical backport first, full edition migration second.**
+   - SOW-0033 must be committed and completed before this SOW moves to `current/`.
+2. **Migration quality - user direction: Rust 2024 is a durable project direction.**
+   - Treat this as a complete migration with compatibility and lifetime validation, not a warning-suppression exercise.
+
+## Plan
+
+1. Complete preliminary inventory and present the MSRV/lifetime design evidence after SOW-0033 closes.
+2. Fill the complete ready Pre-Implementation Gate before moving this SOW to `current/`.
+3. Implement and validate the user-decided migration without mixing unrelated changes.
+
+## Execution Log
+
+### 2026-07-28
+
+- Created as the tracked second step after the user selected the SOW-0033 surgical backport followed by full Rust 2024 migration.
+- Recorded preliminary compiler evidence only; no SOW-0034 implementation started.
+
+## Validation
+
+Acceptance criteria evidence:
+
+- Pending implementation after SOW-0033.
+
+Tests or equivalent validation:
+
+- Preliminary SOW-0033 run: Rust 2024 all-target compatibility linting exposed the benchmark/fixture findings recorded above.
+
+Real-use evidence:
+
+- Pending implementation after SOW-0033.
+
+Reviewer findings:
+
+- Pending implementation after SOW-0033.
+
+Same-failure scan:
+
+- Preliminary diagnostics identify reserved identifiers and drop-order sites; complete scan is pending activation.
+
+Sensitive data gate:
+
+- This pending SOW contains only source paths, public commit hashes, and sanitized compiler-finding summaries.
+
+Artifact maintenance gate:
+
+- AGENTS.md: pending migration analysis.
+- Runtime project skills: pending migration analysis.
+- Specs: pending migration analysis.
+- End-user/operator docs: pending migration analysis.
+- End-user/operator skills: pending migration analysis.
+- SOW lifecycle: remains `open` under `pending/` until SOW-0033 completes and its own gate is ready.
+
+Specs update:
+
+- Pending evidence from migration analysis.
+
+Project skills update:
+
+- Pending evidence from migration analysis.
+
+End-user/operator docs update:
+
+- Pending evidence from migration analysis.
+
+End-user/operator skills update:
+
+- Pending evidence from migration analysis.
+
+Lessons:
+
+- Pending implementation.
+
+Follow-up mapping:
+
+- Pending implementation.
+
+## Outcome
+
+Pending.
+
+## Lessons Extracted
+
+Pending.
+
+## Followup
+
+None yet.
+
+## Regression Log
+
+None yet.

.agents/sow/pending/SOW-0034-20260728-rust-2024-migration.md

@@ -107,7 +107,7 @@ impl ManagedServer {
         {
             let mut guard = self.listener_handle.lock().unwrap();
             if let Some(h) = guard.take() {
-                extern "system" {
+                unsafe extern "system" {
                     fn CloseHandle(h: isize) -> i32;
                 }
                 unsafe {

src/crates/netipc/src/service/raw/server.rs

@@ -4140,7 +4140,7 @@ fn test_poll_fd_eintr_returns_timeout() {
     let mut action: libc::sigaction = unsafe { std::mem::zeroed() };
     let mut old_action: libc::sigaction = unsafe { std::mem::zeroed() };
     action.sa_flags = 0;
-    action.sa_sigaction = noop_signal_handler as usize;
+    action.sa_sigaction = noop_signal_handler as *const () as usize;
     unsafe { libc::sigemptyset(&mut action.sa_mask) };
     assert_eq!(
         unsafe { libc::sigaction(libc::SIGUSR1, &action, &mut old_action) },

src/crates/netipc/src/service/raw_unix_tests.rs

@@ -800,11 +800,11 @@ pub fn cleanup_stale(run_dir: &str, service_name: &str) {
         }
 
         let owner = unsafe { (*hdr).owner_pid };
-        let gen = unsafe { (*hdr).owner_generation };
+        let generation = unsafe { (*hdr).owner_generation };
         unsafe { libc::munmap(map, HEADER_LEN as usize) };
 
         // If owner is dead (or generation is zero / legacy), unlink
-        if !pid_alive(owner) || gen == 0 {
+        if !pid_alive(owner) || generation == 0 {
             let _ = unlink_stale_path(&c_path);
         }
     }
@@ -900,14 +900,16 @@ unsafe fn map_region(fd: i32, region_size: usize) -> *mut libc::c_void {
     #[cfg(test)]
     record_mmap_call();
 
-    libc::mmap(
-        ptr::null_mut(),
-        region_size,
-        libc::PROT_READ | libc::PROT_WRITE,
-        libc::MAP_SHARED,
-        fd,
-        0,
-    )
+    unsafe {
+        libc::mmap(
+            ptr::null_mut(),
+            region_size,
+            libc::PROT_READ | libc::PROT_WRITE,
+            libc::MAP_SHARED,
+            fd,
+            0,
+        )
+    }
 }
 
 #[cfg(test)]
@@ -1141,10 +1143,10 @@ fn check_shm_stale(path: &Path) -> StaleResult {
     }
 
     let owner = unsafe { (*hdr).owner_pid };
-    let gen = unsafe { (*hdr).owner_generation };
+    let generation = unsafe { (*hdr).owner_generation };
     unsafe { libc::munmap(map, HEADER_LEN as usize) };
 
-    if pid_alive(owner) && gen != 0 {
+    if pid_alive(owner) && generation != 0 {
         return StaleResult::LiveServer;
     }