Skip to content

Fix hardcoded absolute path in Android build configuration #97

@mosleim

Description

@mosleim

Problem

The Android build configuration contains a hardcoded absolute path that breaks portability:

File: android/llamalib/build.gradle (Line 27)

Link:

"-DCMAKE_PROJECT_INCLUDE=/Users/adel/Workspace/llama_cpp_dart/darwin/no_bundle.cmake",

Code:

"-DCMAKE_PROJECT_INCLUDE=/Users/adel/Workspace/llama_cpp_dart/darwin/no_bundle.cmake"

Introduced in: Commit 2dce386

Issues with current implementation:

  • Not portable - Path only exists on the original developer's machine (/Users/adel/Workspace/)
  • Breaks for contributors - Other developers cannot build the Android library
  • CI/CD failures - Automated builds will fail when this path doesn't exist
  • Platform mismatch - Android build configuration referencing Darwin (macOS) specific path

Proposed Solution

Replace the hardcoded absolute path with a relative path:

    "-DCMAKE_PROJECT_INCLUDE=${projectDir}/../../darwin/no_bundle.cmake"

Alternative approaches:

  • Use project.rootProject.projectDir. parent to build the path dynamically
  • Move no_bundle.cmake to the Android directory if it's Android-specific
  • Make the include conditional if the file is optional

Impact

  • Affects anyone trying to build the Android library from source
  • Blocks new contributors from building the project
  • May cause silent failures in CI/CD pipelines

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions