Skip to content

Commit b9c1ec0

Browse files
committed
Add some more data-test ids
1 parent 936ad87 commit b9c1ec0

File tree

5 files changed

+19
-5
lines changed

5 files changed

+19
-5
lines changed

web/cypress/integration-tests/netflow_table.cy.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,9 @@ describe('(OCP-50532, OCP-50531, OCP-50530, OCP-59408 Network_Observability) Net
179179
cy.visit('/netflow-traffic')
180180

181181
cy.get('#pageHeader').should('exist').then(() => {
182-
const settings = JSON.parse(localStorage.getItem('netobserv-plugin-settings'))
182+
const rawSettings = localStorage.getItem('netobserv-plugin-settings')
183+
expect(rawSettings, 'netobserv-plugin-settings should exist').to.not.be.null
184+
const settings = JSON.parse(rawSettings as string)
183185
expect(settings['netflow-traffic-refresh']).to.be.equal(15000)
184186
expect(settings['netflow-traffic-size-size']).to.be.equal('s')
185187
expect(settings['netflow-traffic-columns']).to.include('StartTime')

web/src/components/health/health-card.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,13 @@ export const HealthCard: React.FC<HealthCardProps> = ({
9191
}
9292

9393
return (
94-
<Card className={classes.join(' ')} isClickable={onClick !== undefined} isClicked={isSelected}>
94+
<Card
95+
className={classes.join(' ')}
96+
data-test={`health-card-${name || 'global'}`}
97+
isClickable={onClick !== undefined}
98+
isClicked={isSelected}
99+
>
95100
<CardHeader
96-
data-test={`health-card-${name || 'global'}`}
97101
className={hideTitle ? 'card-header-hidden' : 'card-header'}
98102
selectableActions={{
99103
selectableActionAriaLabelledby: `selectable-card-${name || 'global'}`,

web/src/components/health/health-drawer-container.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ export const HealthDrawerContainer: React.FC<HealthDrawerContainerProps> = ({ ti
6161
</span>
6262
</DrawerHead>
6363
{selectedItem && (
64-
<div className="health-gallery-drawer-content">
64+
<div className="health-gallery-drawer-content" data-test="health-drawer-content">
6565
<RuleDetails kind={kind} resourceHealth={selectedItem} />
6666
</div>
6767
)}

web/src/components/health/rule-details.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@ const RuleTableRow: React.FC<{
103103
<Td dataLabel={t('Description')}>{item.description}</Td>
104104
<Td noPadding>
105105
<ActionsColumn
106+
data-test="rule-details-actions"
106107
isDisabled={links.length === 0}
107108
items={links.map(l => ({ title: <a href={l.url}>{l.name}</a> }))}
108109
/>
@@ -124,7 +125,7 @@ const RuleCard: React.FC<{
124125
const direction = React.useMemo(() => getDirection(item.ruleName), [item]);
125126

126127
return (
127-
<div className="rule-details-row">
128+
<div className="rule-details-row" data-test="rule-details-row">
128129
<Flex direction={{ default: 'column' }} gap={{ default: 'gapSm' }}>
129130
{/* Header with summary and actions */}
130131
<Flex
@@ -153,6 +154,7 @@ const RuleCard: React.FC<{
153154
</FlexItem>
154155
<FlexItem>
155156
<ActionsColumn
157+
data-test="rule-details-actions"
156158
isDisabled={links.length === 0}
157159
items={links.map(l => ({ title: <a href={l.url}>{l.name}</a> }))}
158160
/>

web/src/components/metrics/histogram.tsx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,7 @@ export const Histogram: React.FC<HistogramProps> = ({
272272
isVisible={tooltipsTrigger === 'manual' ? false : undefined}
273273
>
274274
<Button
275+
data-test="histogram-double-left"
275276
icon={<AngleDoubleLeftIcon />}
276277
variant="plain"
277278
className={`metrics-content-button ${loading ? 'loading' : ''}`}
@@ -285,6 +286,7 @@ export const Histogram: React.FC<HistogramProps> = ({
285286
isVisible={tooltipsTrigger === 'manual' ? false : undefined}
286287
>
287288
<Button
289+
data-test="histogram-single-left"
288290
icon={<AngleLeftIcon />}
289291
variant="plain"
290292
className={`metrics-content-button ${loading ? 'loading' : ''}`}
@@ -303,6 +305,7 @@ export const Histogram: React.FC<HistogramProps> = ({
303305
isVisible={tooltipsTrigger === 'manual' ? false : undefined}
304306
>
305307
<Button
308+
data-test="histogram-single-right"
306309
icon={<AngleRightIcon />}
307310
variant="plain"
308311
className={`metrics-content-button ${loading ? 'loading' : ''}`}
@@ -315,6 +318,7 @@ export const Histogram: React.FC<HistogramProps> = ({
315318
isVisible={tooltipsTrigger === 'manual' ? false : undefined}
316319
>
317320
<Button
321+
data-test="histogram-double-right"
318322
icon={<AngleDoubleRightIcon />}
319323
variant="plain"
320324
className={`metrics-content-button ${loading ? 'loading' : ''}`}
@@ -331,6 +335,7 @@ export const Histogram: React.FC<HistogramProps> = ({
331335
isVisible={tooltipsTrigger === 'manual' ? false : undefined}
332336
>
333337
<Button
338+
data-test="histogram-zoom-out"
334339
icon={<SearchMinusIcon />}
335340
variant="plain"
336341
className={`metrics-content-button ${loading ? 'loading' : ''}`}
@@ -346,6 +351,7 @@ export const Histogram: React.FC<HistogramProps> = ({
346351
isVisible={tooltipsTrigger === 'manual' ? false : undefined}
347352
>
348353
<Button
354+
data-test="histogram-zoom-in"
349355
icon={<SearchPlusIcon />}
350356
variant="plain"
351357
className={`metrics-content-button ${loading ? 'loading' : ''}`}

0 commit comments

Comments
 (0)