kvcache-aware-scorer fails on misconfig

Signed-off-by: Maroon Ayoub <[email protected]>

Author: vMaroon

pkg/epp/scheduling/plugins/scorers/kvcache-aware-scorer.go

@@ -34,6 +34,8 @@ import (
 const (
 	kvCacheAwareScorerName  = "KVCacheAwareScorer"
 	cacheStalenessThreshold = 5 * time.Second
+	kvCacheRedisEnvVar      = "KVCACHE_INDEXER_REDIS_ADDR"
+	huggingFaceTokenEnvVar  = "HF_TOKEN"
 )
 
 // KVCacheAwareScorer is a concrete implementation of the Scorer interface.
@@ -45,29 +47,29 @@ type KVCacheAwareScorer struct {
 	scoresCacheLastUpdate time.Time
 }
 
-func kvCacheIndexerConfigFromEnv() *kvcache.Config {
+// NewKVCacheAwareScorer creates a new KVCacheAwareScorer instance.
+// It initializes the KVCacheIndexer with the provided configuration,
+// and runs it with the given context.
+//
+// If the configuration is nil, it uses the default configuration.
+func NewKVCacheAwareScorer(ctx context.Context) (types.Scorer, error) {
 	config := kvcache.NewDefaultConfig()
 
-	redisAddr := os.Getenv("KVCACHE_INDEXER_REDIS_ADDR")
+	redisAddr := os.Getenv(kvCacheRedisEnvVar)
 	if redisAddr != "" {
 		config.KVBlockIndexerConfig.RedisKVBlockIndexerConfig.RedisAddr = redisAddr
+	} else {
+		return nil, fmt.Errorf("environment variable %s is not set", kvCacheRedisEnvVar)
 	}
 
-	hfToken := os.Getenv("HF_TOKEN")
+	hfToken := os.Getenv(huggingFaceTokenEnvVar)
 	if hfToken != "" {
 		config.TokenizersPoolConfig.HFTokenizerConfig.HuggingFaceToken = hfToken
+	} else {
+		return nil, fmt.Errorf("environment variable %s is not set", huggingFaceTokenEnvVar)
 	}
 
-	return config
-}
-
-// NewKVCacheAwareScorer creates a new KVCacheAwareScorer instance.
-// It initializes the KVCacheIndexer with the provided configuration,
-// and runs it with the given context.
-//
-// If the configuration is nil, it uses the default configuration.
-func NewKVCacheAwareScorer(ctx context.Context) (types.Scorer, error) {
-	kvCacheIndexer, err := kvcache.NewKVCacheIndexer(kvCacheIndexerConfigFromEnv())
+	kvCacheIndexer, err := kvcache.NewKVCacheIndexer(config)
 	if err != nil {
 		return nil, fmt.Errorf("failed to create KVCacheIndexer: %w", err)
 	}