-
Notifications
You must be signed in to change notification settings - Fork 25
Description
Currently datashuttle
configs are held in the Configs
class and passed around, used to get canonical confirmation as well as the datashuttle configs. This held a few rclone-config related attributes but with the extension of RClone config handling in #600 this was factored into an RCloneConfigs
class that is attached to Configs
.
This is now confusing, because the datashuttle-configs option now is also now managing the RClone configs. This was done for now as the Config
class is passed across the codebase so it is very cocnvenient to have all this information on one place.
The neatest fix will be to have a make the currently Configs
class into DataShuttleConfigs
and then have Configs
as a central class that manages all configs and holds RCloneConfigs
and DataShuttleConfigs
. This is then convenient as all configs are in one place, but the logic is clearly separated and extensible.