Repository navigation
feat!: remove style.css export - #2675
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2675 +/- ##
=======================================
Coverage 61.74% 61.74%
=======================================
Files 15 15
Lines 481 481
Branches 104 103 -1
=======================================
Hits 297 297
Misses 165 165
Partials 19 19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
👍 |
Merged
Antreesy
marked this pull request as ready for review
October 26, 2026 15:08
- Reverts ca2f0c6 for v8, styles are imported by the JS entries again (`inlineCSS`). - `dist/style.css` is no longer generated, which is a breaking change for apps that import `@nextcloud/dialogs/style.css`. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
feat/inline-css-v8
branch
from
October 26, 2026 15:14
f893818 to
b187146
Compare
- Styles are imported automatically by the package entry points, so the `./style.css` export is removed from `package.json`. - Update the README, apps no longer need to import `@nextcloud/dialogs/style.css`. - Add a breaking change note for v8 to the changelog. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
feat/inline-css-v8
branch
from
October 26, 2026 15:19
b187146 to
d4a1359
Compare
susnux
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nextcloud/dialogs/style.cssoutput #2672./style.cssexport is removed frompackage.json.@nextcloud/dialogs/style.css.🤖 AI (if applicable)