Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed item lists are merged when filtered #2516

Closed
stmichalke opened this issue Dec 21, 2023 · 6 comments · Fixed by #2814
Closed

Feed item lists are merged when filtered #2516

stmichalke opened this issue Dec 21, 2023 · 6 comments · Fixed by #2814
Labels

Comments

@stmichalke
Copy link

stmichalke commented Dec 21, 2023

IMPORTANT

Read and tick the following checkbox after you have created the issue or place an x inside the brackets ;)

  • [ x] I have read the CONTRIBUTING.md and followed the provided tips
  • [ x] I accept that the issue will be closed without comment if I do not check here
  • [ x] I accept that the issue will be closed without comment if I do not fill out all items in the issue template.

Explain the Problem

Several feed item lists are merged after switching from the filtered view (unread) to another list.

Steps to Reproduce

Explain what you did to encounter the issue

  1. Open a feed.
  2. Filter the unread items.
  3. Open another feed.
  4. The two feeds are now entangled.
  5. Unfilter again.
  6. Only items of the last feed are displayed.
  7. Filter the unread items again.
  8. Everything is fine.

System Information

  • News app version: 25.0.0-alpha2
  • Nextcloud version: 28.0.1.1
  • Cron type: system cron
  • PHP version: 8.2.7
  • Database and version: PostgreSQL 16.1
  • Browser and version: Firefox 120.1.1 for Android
  • OS and version: Debian 12.4
Contents of nextcloud/data/nextcloud.log

{"reqId":"OP4pxVvhG1RdfuRXo5rO","level":4,"time":"2023-12-21T17:45:36+00:00","remoteAddr":"","user":"","app":"no app in context","method":"GET","url":"/apps/news/items?limit=40&oldestFirst=false&search=&showAll=true&type=0&offset=1185831&id=293","message":"Could not boot metadata: Call to undefined method OC\Server::getEventDispatcher()","userAgent":"Mozilla/5.0 (Android 13; Mobile; rv:120.0) Gecko/120.0 Firefox/120.0","version":"28.0.1.1","exception":{"Exception":"Error","Message":"Call to undefined method OC\Server::getEventDispatcher()","Code":0,"Trace":[{"file":"<doc_root>/lib/private/AppFramework/Bootstrap/Coordinator.php","line":200,"function":"boot","class":"OCA\Metadata\AppInfo\Application","type":"->"},{"file":"<doc_root>/lib/private/App/AppManager.php","line":434,"function":"bootApp","class":"OC\AppFramework\Bootstrap\Coordinator","type":"->"},{"file":"<doc_root>/lib/private/App/AppManager.php","line":213,"function":"loadApp","class":"OC\App\AppManager","type":"->"},{"file":"<doc_root>/lib/private/legacy/OC_App.php","line":125,"function":"loadApps","class":"OC\App\AppManager","type":"->"},{"file":"<doc_root>/lib/base.php","line":1049,"function":"loadApps","class":"OC_App","type":"::"},{"file":"<doc_root>/index.php","line":39,"function":"handleRequest","class":"OC","type":"::"}],"File":"<doc_root>/apps/metadata/lib/AppInfo/Application.php","Line":28,"message":"Could not boot metadata: Call to undefined method OC\Server::getEventDispatcher()","exception":{},"CustomMessage":"Could not boot metadata: Call to undefined method OC\Server::getEventDispatcher()"}}
{"reqId":"BGJrPLckNTOsDph1JMVE","level":4,"time":"2023-12-21T17:45:38+00:00","remoteAddr":"","user":"","app":"no app in context","method":"GET","url":"/apps/news/items?limit=40&oldestFirst=false&search=&showAll=true&type=0&offset=1185831&id=293","message":"Could not boot metadata: Call to undefined method OC\Server::getEventDispatcher()","userAgent":"Mozilla/5.0 (Android 13; Mobile; rv:120.0) Gecko/120.0 Firefox/120.0","version":"28.0.1.1","exception":{"Exception":"Error","Message":"Call to undefined method OC\Server::getEventDispatcher()","Code":0,"Trace":[{"file":"<doc_root>/lib/private/AppFramework/Bootstrap/Coordinator.php","line":200,"function":"boot","class":"OCA\Metadata\AppInfo\Application","type":"->"},{"file":"<doc_root>/lib/private/App/AppManager.php","line":434,"function":"bootApp","class":"OC\AppFramework\Bootstrap\Coordinator","type":"->"},{"file":"<doc_root>/lib/private/App/AppManager.php","line":213,"function":"loadApp","class":"OC\App\AppManager","type":"->"},{"file":"<doc_root>/lib/private/legacy/OC_App.php","line":125,"function":"loadApps","class":"OC\App\AppManager","type":"->"},{"file":"<doc_root>/lib/base.php","line":1049,"function":"loadApps","class":"OC_App","type":"::"},{"file":"<doc_root>/index.php","line":39,"function":"handleRequest","class":"OC","type":"::"}],"File":"<doc_root>/apps/metadata/lib/AppInfo/Application.php","Line":28,"message":"Could not boot metadata: Call to undefined method OC\Server::getEventDispatcher()","exception":{},"CustomMessage":"Could not boot metadata: Call to undefined method OC\Server::getEventDispatcher()"}}

Contents of Browser Error Console n.a. in mobile version

Screenshot

@stmichalke stmichalke added the bug label Dec 21, 2023
@pludi
Copy link

pludi commented Aug 13, 2024

This looks like an Android App error which is tracked in a separate repo: nextcloud/news-android

@powerpaul17
Copy link
Contributor

It's the firefox browser on an Android device.

@SMillerDev
Copy link
Contributor

News app version: 25.0.0-alpha2

Does it still occur with Alpha 8?

@stmichalke
Copy link
Author

Yes. I've just tested it with latest FF for Android and Kiwi Browser.

@SMillerDev
Copy link
Contributor

But also with the latest news release?

@stmichalke
Copy link
Author

stmichalke commented Aug 13, 2024

news: 25.0.0-alpha8
Nextcloud 29.0.4

--
BTW, epiphany-browser 43.1 @ Debian 12.4/amd64 shows the same behaviour.

Grotax added a commit that referenced this issue Oct 19, 2024
Fixed
- First features for user settings after vue migration (#2795)
- scroll stops after first bunch of items when they are marked read during scroll (#2814)
- marked read items disappear when showAll is disabled in folder or feed view (#2814)
- Feed item lists are merged when filtered (#2516)
- Mark as read on Scroll (#2503)
- Open news with the last viewed feed or folder (#2507)

Signed-off-by: Benjamin Brahmer <[email protected]>
Grotax added a commit that referenced this issue Oct 19, 2024
Fixed
- First features for user settings after vue migration (#2795)
- scroll stops after first bunch of items when they are marked read during scroll (#2814)
- marked read items disappear when showAll is disabled in folder or feed view (#2814)
- Feed item lists are merged when filtered (#2516)
- Mark as read on Scroll (#2503)
- Open news with the last viewed feed or folder (#2507)

Signed-off-by: Benjamin Brahmer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants