Skip to content

Commit 2abd5d3

Browse files
committed
ci: move error pages outside of the public-api group (#49770)
Currently, a change in an error guide triggers a review for the `public-api` group (requests 3 reviewers and al least 2 must approve). This is overly aggressive and we can relax this by moving the guides under `fw-core` and extended diagnistics under `fw-compiler`. In this case 1 reviewer would be requested. PR Close #49770
1 parent 3e1ec58 commit 2abd5d3

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

.pullapprove.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,8 @@ groups:
158158
'aio/content/guide/angular-compiler-options.md',
159159
'aio/content/guide/aot-compiler.md',
160160
'aio/content/guide/aot-metadata-errors.md',
161-
'aio/content/guide/template-typecheck.md'
161+
'aio/content/guide/template-typecheck.md',
162+
'aio/content/extended-diagnostics/*.md'
162163
])
163164
reviewers:
164165
users:
@@ -241,6 +242,8 @@ groups:
241242
'aio/content/examples/component-interaction/**/{*,.*}',
242243
'aio/content/images/guide/component-interaction/**/{*,.*}',
243244
'aio/content/guide/component-overview.md',
245+
'aio/content/errors/*.md',
246+
'aio/content/examples/errors/**/{*,.*}',
244247
'aio/content/examples/component-overview/**/{*,.*}',
245248
'aio/content/guide/component-styles.md',
246249
'aio/content/guide/developer-guide-overview.md',
@@ -1204,11 +1207,8 @@ groups:
12041207
'goldens/public-api/**/{*,.*}',
12051208
'docs/NAMING.md',
12061209
'aio/content/guide/angular-package-format.md',
1207-
'aio/content/errors/*.md',
1208-
'aio/content/extended-diagnostics/*.md',
12091210
'aio/content/guide/glossary.md',
12101211
'aio/content/guide/styleguide.md',
1211-
'aio/content/examples/errors/**/{*,.*}',
12121212
'aio/content/examples/styleguide/**/{*,.*}',
12131213
'aio/content/images/guide/styleguide/{*,.*}'
12141214
])

0 commit comments

Comments
 (0)