Ordering (github#35558)

Author: heiskr

.github/actions/clone-translations/action.yml

@@ -17,13 +17,6 @@ runs:
         token: ${{ inputs.token }}
         path: translations/zh-cn
 
-    - name: Clone Japanese
-      uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
-      with:
-        repository: github/docs-internal.ja-jp
-        token: ${{ inputs.token }}
-        path: translations/ja-jp
-
     - name: Clone Spanish
       uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
       with:
@@ -38,12 +31,19 @@ runs:
         token: ${{ inputs.token }}
         path: translations/pt-br
 
-    - name: Clone German
+    - name: Clone Russian
       uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
       with:
-        repository: github/docs-internal.de-de
+        repository: github/docs-internal.ru-ru
         token: ${{ inputs.token }}
-        path: translations/de-de
+        path: translations/ru-ru
+
+    - name: Clone Japanese
+      uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
+      with:
+        repository: github/docs-internal.ja-jp
+        token: ${{ inputs.token }}
+        path: translations/ja-jp
 
     - name: Clone French
       uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
@@ -52,12 +52,12 @@ runs:
         token: ${{ inputs.token }}
         path: translations/fr-fr
 
-    - name: Clone Russian
+    - name: Clone German
       uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
       with:
-        repository: github/docs-internal.ru-ru
+        repository: github/docs-internal.de-de
         token: ${{ inputs.token }}
-        path: translations/ru-ru
+        path: translations/de-de
 
     - name: Clone Korean
       uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8

.github/workflows/sync-search-elasticsearch.yml

@@ -48,7 +48,7 @@ jobs:
           script: |
             // Edit this list for the definitive list of languages
             // (other than English) we want to index in Elasticsearch.
-            const allNonEnglish = ["ja", "es", "pt", "zh", "ru", "fr", "ko", "de"]
+            const allNonEnglish = ["zh", "es", "pt", "ru", "ja", "fr", "de", "ko"]
             const allPossible = ["en", ...allNonEnglish]
 
             if (context.eventName === "workflow_run") {

.github/workflows/test.yml

@@ -44,15 +44,15 @@ jobs:
             return [
               { name: 'content', path: 'tests/content', },
               { name: 'graphql', path: 'tests/graphql', },
+              { name: 'events', path: 'src/events/tests', },
+              { name: 'linting', path: 'tests/linting', },
               { name: 'meta', path: 'tests/meta', },
-              { name: 'rendering', path: 'tests/rendering', },
               { name: 'routing', path: 'tests/routing', },
-              { name: 'unit', path: 'tests/unit', },
-              { name: 'linting', path: 'tests/linting', },
+              { name: 'rendering', path: 'tests/rendering', },
               { name: 'rendering-fixtures', path: 'tests/rendering-fixtures', },
-              { name: 'events', path: 'src/events/tests', },
               context.payload.repository.full_name === 'github/docs-internal' &&
                 { name: 'translations', path: 'tests/translations', },
+              { name: 'unit', path: 'tests/unit', },
             ].filter(Boolean)
 
   test:

.github/workflows/translation-health-report.yml

@@ -24,29 +24,25 @@ jobs:
       fail-fast: false
       matrix:
         include:
+          - language: zh
+            language_dir: translations/zh-cn
+            language_repo: github/docs-internal.zh-cn
+
           - language: es
             language_dir: translations/es-es
             language_repo: github/docs-internal.es-es
 
-          - language: ja
-            language_dir: translations/ja-jp
-            language_repo: github/docs-internal.ja-jp
-
           - language: pt
             language_dir: translations/pt-br
             language_repo: github/docs-internal.pt-br
 
-          - language: zh
-            language_dir: translations/zh-cn
-            language_repo: github/docs-internal.zh-cn
-
           - language: ru
             language_dir: translations/ru-ru
             language_repo: github/docs-internal.ru-ru
 
-          - language: ko
-            language_dir: translations/ko-kr
-            language_repo: github/docs-internal.ko-kr
+          - language: ja
+            language_dir: translations/ja-jp
+            language_repo: github/docs-internal.ja-jp
 
           - language: fr
             language_dir: translations/fr-fr
@@ -56,6 +52,9 @@ jobs:
             language_dir: translations/de-de
             language_repo: github/docs-internal.de-de
 
+          - language: ko
+            language_dir: translations/ko-kr
+            language_repo: github/docs-internal.ko-kr
     steps:
       - name: Checkout the docs-internal repo
         uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8

Dockerfile

@@ -107,7 +107,7 @@ FROM preview as production
 
 # Override what was set for previews
 # Make this match the default of `Object.keys(languages)` in lib/languages.js
-ENV ENABLED_LANGUAGES "en,zh,ja,es,pt,de,fr,ru,ko"
+ENV ENABLED_LANGUAGES "en,zh,es,pt,ru,ja,fr,de,ko"
 
 # Copy in all translations
 COPY --chown=node:node translations ./translations

contributing/search.md

@@ -19,7 +19,7 @@ You can also query our search endpoint directly at:
 `https://docs.github.com/search?version=<VERSION>&language=<LANGUAGE CODE>&filters=topics:<TOPIC>&query=<QUERY>`
 
 - The VERSION can be any numbered GitHub Enterprise Server version (e.g., `2.22`, `3.0`), GitHub AE (`ghae`), or the Free pro team plan (`dotcom`).
-- The LANGUAGE CODE can be: `zh`, `de`, `en`, `es`, `ja`, or `pt`.
+- The LANGUAGE CODE can be one of: `zh`, `es`, `pt`, `ru`, `ja`, `fr`, `de`, `ko`
 - TOPIC can be any topics in [the allowed list of topics](/data/allowed-topics.js). The values in the `topics` attribute are **not** case sensitive, so filtering on `GitHub actions` or `github actions` will return the same result. **Note:** Currently, the topics filter only works for the dotcom version in the English language. We plan to expand this search query to other languages and versions in the future.
 - Any search QUERY you'd like.
 
@@ -94,18 +94,15 @@ There's a separate search index for each combination of product and language. So
 
 Index Name | Description
 ---------- | -----------
-`github-docs-dotcom-zh` | GitHub.com Chinese
 `github-docs-dotcom-en` | GitHub.com English
+`github-docs-dotcom-zh` | GitHub.com Chinese
 `github-docs-dotcom-es` | GitHub.com Spanish
-`github-docs-dotcom-ja` | GitHub.com Japanese
-`github-docs-2.18-zh` | GitHub Enterprise 2.18 Chinese
 `github-docs-2.18-en` | GitHub Enterprise 2.18 English
+`github-docs-2.18-zh` | GitHub Enterprise 2.18 Chinese
 `github-docs-2.18-es` | GitHub Enterprise 2.18 Spanish
-`github-docs-2.18-ja` | GitHub Enterprise 2.18 Japanese
-`github-docs-2.17-zh` | GitHub Enterprise 2.17 Chinese
 `github-docs-2.17-en` | GitHub Enterprise 2.17 English
+`github-docs-2.17-zh` | GitHub Enterprise 2.17 Chinese
 `github-docs-2.17-es` | GitHub Enterprise 2.17 Spanish
-`github-docs-2.17-ja` | GitHub Enterprise 2.17 Japanese
 
 ## Records
 

lib/languages.js

@@ -10,13 +10,13 @@ import path from 'path'
 dotenv.config()
 
 const possibleEnvVars = {
-  'es-es': process.env.TRANSLATIONS_ROOT_ES_ES,
   'zh-cn': process.env.TRANSLATIONS_ROOT_ZH_CN,
-  'ja-jp': process.env.TRANSLATIONS_ROOT_JA_JP,
+  'es-es': process.env.TRANSLATIONS_ROOT_ES_ES,
   'pt-br': process.env.TRANSLATIONS_ROOT_PT_BR,
-  'de-de': process.env.TRANSLATIONS_ROOT_DE_DE,
-  'fr-fr': process.env.TRANSLATIONS_ROOT_FR_FR,
   'ru-ru': process.env.TRANSLATIONS_ROOT_RU_RU,
+  'ja-jp': process.env.TRANSLATIONS_ROOT_JA_JP,
+  'fr-fr': process.env.TRANSLATIONS_ROOT_FR_FR,
+  'de-de': process.env.TRANSLATIONS_ROOT_DE_DE,
   'ko-kr': process.env.TRANSLATIONS_ROOT_KO_KR,
 }