Skip to content

Commit bc3dff1

Browse files
downingaralessfg
andauthored
fix: Correct default http_version from float to string (#439)
Co-authored-by: Alessandro Fael Garcia <[email protected]>
1 parent 450e464 commit bc3dff1

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ BUG FIXES:
1414
- Correct cleanup error when `nginx_config_cleanup_paths` is not defined.
1515
- Disable check_mode for `jinja2_version` and Ansible collections validation tasks.
1616
- The default PID path has changed as of NGINX 1.27.5 and 1.28.0.
17+
- Properly wrap `http_version` number in quotes in both the template defaults and Molecule tests.
1718
- NGINX `set_real_ip_from` directive template parameter should be a list.
1819

1920
TESTS:

defaults/main/template.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,7 @@ nginx_config_http_template:
436436
headers_hash_bucket_size: 64
437437
headers_hash_max_size: 512
438438
hide_header: Date # String or a list of strings
439-
http_version: 1.1 # Can be set to '1.0' or '1.1'
439+
http_version: '1.1' # Can be set to '1.0' or '1.1'
440440
ignore_client_abort: false # Boolean
441441
ignore_headers: X-Accel-Redirect # String or a list of strings -- Can be set to 'X-Accel-Redirect', 'X-Accel-Expires', 'X-Accel-Limit-Rate', 'X-Accel-Buffering', 'X-Accel-Charset', 'Expires', 'Cache-Control', 'Set-Cookie' or 'Vary'
442442
intercept_errors: false # Boolean

molecule/complete/converge.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,7 @@
349349
hide_header:
350350
- Date
351351
- X-Accel-Redirect
352-
http_version: 1.1
352+
http_version: '1.1'
353353
ignore_client_abort: false
354354
ignore_headers:
355355
- X-Accel-Redirect
@@ -460,7 +460,7 @@
460460
comp_level: 1
461461
disable:
462462
- '"msie6"'
463-
http_version: 1.1
463+
http_version: '1.1'
464464
min_length: 20
465465
proxied:
466466
- expired

molecule/complete_plus/converge.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@
208208
comp_level: 1
209209
disable:
210210
- '"msie6"'
211-
http_version: 1.1
211+
http_version: '1.1'
212212
min_length: 20
213213
proxied:
214214
- expired
@@ -478,7 +478,7 @@
478478
hide_header:
479479
- Date
480480
- X-Accel-Redirect
481-
http_version: 1.1
481+
http_version: '1.1'
482482
ignore_client_abort: false
483483
ignore_headers:
484484
- X-Accel-Redirect

0 commit comments

Comments
 (0)