Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untangle locale-setting code #847

Open
d235j opened this issue Jan 29, 2024 · 1 comment
Open

Untangle locale-setting code #847

d235j opened this issue Jan 29, 2024 · 1 comment
Assignees
Milestone

Comments

@d235j
Copy link
Collaborator

d235j commented Jan 29, 2024

At the moment the locale-setting code (in lib/scopehal/Unit.h) uses the C API and does not appear thread-safe on Windows. Additionally, on macOS it seems to not correctly reset the locale on application exit.

Previously there were issues with file interchange due to locale (#494). The OS is supposed to set the application's locale to C on startup, but obviously something isn't right, so this needs to be thoroughly investigated to clean up the API calls and prevent further interchange issues.

@azonenberg
Copy link
Collaborator

Conjecture: GTK was doing something with locales in glscopeclient that might no longer be an issue now that we're not using GTK?

@azonenberg azonenberg added this to the v0.1 milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants