Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align visually hidden behaviour with GOV.UK Frontend #1169

Open
colinrotherham opened this issue Mar 5, 2025 · 0 comments · May be fixed by #1170
Open

Align visually hidden behaviour with GOV.UK Frontend #1169

colinrotherham opened this issue Mar 5, 2025 · 0 comments · May be fixed by #1170
Assignees

Comments

@colinrotherham
Copy link
Contributor

colinrotherham commented Mar 5, 2025

There are a number of issues against visually-hidden behaviour:

We should see if these are resolved by GOV.UK Frontend

Visually hidden

For example, we can see various visually-hidden changes in:

Visually shown

But we should likely deprecate and remove visually-shown (see #1168) to prevent conflicting styles.

I'd recommend a targetted visually-hidden instead:

Before

@include visually-hidden; // [1]

@include mq($from: desktop) {
  @include visually-shown($display: table-header-group); // [2]
}

After

@include mq($until: desktop) {
  @include visually-hidden; // [1]
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs review
Development

Successfully merging a pull request may close this issue.

1 participant